[Due for payment 2025-05-28] [$250] Receipt thumbnail doesn't update when a new receipt is attached

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.32-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @twisterdotcom
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. User have a card expense and eReceipt generated
2. Navigate to Reports and click on the expenses
3. Click on the receipt and replace the receipt

Expected Result:

The receipt thumbnail should immediately update to show the newly attached receipt.

Actual Result:

The old thumbnail remains, even after a new receipt is attached.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1159.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915861903002576485
• Upwork Job ID: 1915861903002576485
• Last Price Increase: 2025-05-02
• Automatic offers:
• ishakakkad | Contributor | 107197775

Issue Owner

Current Issue Owner: @CortneyOfstad / @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-25 17:28:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Receipt thumbnail doesn't update when a new receipt is attached

What is the root cause of that problem?

This happen due to

App/src/components/SelectionList/Search/TransactionListItemRow.tsx

Line 117 in 4a087a6

isEReceipt={transactionItem.hasEReceipt && !hasReceiptSource(transactionItem)}

Even when the source has been changes this condition remain true leading to show eReceipt instead of updating the source

What changes do you think we should make in order to solve the problem?

We should explicitly add !source here

isEReceipt={transactionItem.hasEReceipt && !hasReceiptSource(transactionItem) && !source}

so this will not remain on preview as soon the source will be available

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[joekaufmanexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915861903002576485

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Receipt thumbnail doesn't update when a new receipt is attached

What is the root cause of that problem?

Search List items are ultimately wrapped by useCallback hook here.

App/src/components/Search/SearchList.tsx

Line 291 in 89588cd

const renderItem = useCallback(

But it does not contain data in dependency list.
so ultimately renderItem function does not depend upon data and hence it returns the same old memoized version of the ListItem which contains eReceipt as thumbnail.

What changes do you think we should make in order to solve the problem?

Add data to dependency list here to re trigger the renderItem function when data changes.

App/src/components/Search/SearchList.tsx

Line 329 in 89588cd

ListItem,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Alternatively remove useCallback hook from renderItem which is not most suitable option but could be used in case any other issues are found.

App/src/components/Search/SearchList.tsx

Line 291 in 89588cd

const renderItem = useCallback(

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.