[Due for payment 2026-06-18] [$250] Report - Supplier Address & VAT Number report fields are shown in settings but not shown in the report

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.30-1
Reproducible in staging?: Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sdhbhsdiuhsiudh@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create an EUR workspace
3. Go to workspace settings > Reports
4. Enable Report fields
5. Click Upgrade > Got it, thanks
   → Supplier Address and VAT Number text type report fields appear when the workspace currency is EUR
6. Go to workspace chat
7. Create an empty report
8. Open the empty report
9. Create an expense in the empty report

Expected Result:

Supplier Address and VAT Number report fields will appear in the report since the report fields are present on workspace settings > Reports

Actual Result:

Supplier Address and VAT Number report fields are not shown in the report when the report fields are present on workspace settings > Reports

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6974515_1760449106599.eur.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021979200514033151425
• Upwork Job ID: 1979200514033151425
• Last Price Increase: 2025-10-24

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ShridharGoel]

🚨 Edited by proposal-police: This proposal was edited at 2025-10-23 16:58:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace admins see supplier address, VAT, and any other invoice-only fields under the Report fields section. Those options should appear under Invoices instead, and new invoice-only custom fields must stay out of the report configuration page.

What is the root cause of that problem?

The report settings screen reads every policy field whose id is not text_title. It never checks the field target, so invoice-targeted fields are mixed in with actual report fields.

App/src/pages/workspace/reports/WorkspaceReportsPage.tsx

Lines 70 to 105 in 582e7c5

	const connectedIntegration = getConnectedIntegration(policy) ?? connectionSyncProgress?.connectionName;
	const isConnectionVerified = connectedIntegration && !isConnectionUnverified(policy, connectedIntegration);
	const currentConnectionName = getCurrentConnectionName(policy);
	const hasAccountingConnections = hasAccountingConnectionsPolicyUtils(policy);
	const filteredPolicyFieldList = useMemo(() => {
	if (!policy?.fieldList) {
	return {};
	}
	// eslint-disable-next-line @typescript-eslint/no-unused-vars
	return Object.fromEntries(Object.entries(policy.fieldList).filter(([_, value]) => value.fieldID !== 'text_title'));
	}, [policy]);
	const [isOrganizeWarningModalOpen, setIsOrganizeWarningModalOpen] = useState(false);
	const illustrations = useMemoizedLazyIllustrations(['ReportReceipt'] as const);
	const onDisabledOrganizeSwitchPress = useCallback(() => {
	if (!hasAccountingConnections) {
	return;
	}
	setIsOrganizeWarningModalOpen(true);
	}, [hasAccountingConnections]);
	const fetchReportFields = useCallback(() => {
	openPolicyReportFieldsPage(policyID);
	}, [policyID]);
	const {isOffline} = useNetwork({onReconnect: fetchReportFields});
	useEffect(() => {
	fetchReportFields();
	}, [fetchReportFields]);
	const reportFieldsSections = useMemo(() => {
	if (!policy) {
	return [];
	}

What changes do you think we should make in order to solve the problem?

1. Update the report settings filter so it ignores invoice-targeted fields (or we can just check for equality of target).

// WorkspaceReportsPage.tsx
return Object.fromEntries(
    Object.entries(policy.fieldList).filter(
        ([, value]) => value.fieldID !== 'text_title' && value.target !== CONST.REPORT_FIELD_TARGETS.INVOICE,
    ),
);

2. Extend the create-field flow so the caller passes the desired target, and have the form give that out to the optimistic update and the report merge logic.

// ReportField.ts
type CreateReportFieldParams = Pick<WorkspaceReportFieldForm, 'name' | 'type' | 'initialValue'> & {
    ...
    policyReportIDs: Array<string | undefined> | undefined;
    target?: PolicyReportField['target'];
    ...
};

function createReportField({... , policyReportIDs, target = CONST.REPORT_FIELD_TARGETS.EXPENSE, policy}: CreateReportFieldParams) {
    ...
    const optimisticReportFieldDataForPolicy = {
        ...
        target,
        ...
    };
    const optimisticData = [
        {
            ...
        },
        ...(policyReportIDs ?? []).map((reportID) => ({
            ...
        })),
    ];

3. Allow the create-field route to carry an optional target query param, and pass it through the form so invoice fields only merge into invoice reports.

// ROUTES.ts
WORKSPACE_CREATE_REPORT_FIELD: {
    ...
    getRoute: (policyID, target) =>
        target ? `${baseRoute}?target=${encodeURIComponent(target)}` : baseRoute,
},

// CreateReportFieldsPage.tsx
const fieldTarget = useMemo(() => (
    target && Object.values(CONST.REPORT_FIELD_TARGETS).includes(target)
        ? target
        : CONST.REPORT_FIELD_TARGETS.EXPENSE
), [target]);

const policyReportIDsSelector = useCallback(
    (reports) =>
        Object.values(reports ?? {})
            .filter((report) => report?.policyID === policyID && report.type === reportTypeForTarget)
            .map((report) => report?.reportID),
    [policyID, reportTypeForTarget],
);

4. Add a new Invoice fields section under the invoices workspace tab that mirrors the existing report fields UI but only surfaces invoice-targeted data. The menu loads policy fields, lets admins navigate into field settings, and links the add button to the same form but tagged with the invoice target.

// WorkspaceInvoiceFieldsSection.tsx
const invoiceFields = useMemo(() =>
    Object.values(policy?.fieldList ?? {})
        .filter((field) => field.target === CONST.REPORT_FIELD_TARGETS.INVOICE)
        .sort((a, b) => localeCompare(a.name, b.name))
        .map((field) => ({
            text: field.name,
            keyForList: String(field.fieldID),
            ...
        })),
[localeCompare, policy?.fieldList, translate]);

<MenuItem
    onPress={() => Navigation.navigate(
        ROUTES.WORKSPACE_CREATE_REPORT_FIELD.getRoute(policyID, CONST.REPORT_FIELD_TARGETS.INVOICE),
    )}
    title={translate('workspace.reportFields.addField')}
    icon={Plus}
    ...
/>

5. Add new translation keys for invoice fields so the UI copy matches the design (invoice switch label, subtitles, disable modal text).

// en.ts
workspace: {
    common: {
        invoiceFields: 'Invoice fields',
    },
    invoiceFields: {
        subtitle: "Invoice fields can be helpful when you'd like to include extra information.",
        ...
    },
},

Note: We'll need to either add a new endpoint for invoice fields, or within the same endpoint we can have a new query param/identifier in request body to tell the backend that the enabling is being done for reports or invoices (since it can happen that one of these might be enabled and the other might not be).

Screen.Recording.2025-10-23.at.10.55.17.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021979200514033151425

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[abekkala]

@rojiphil we did already receive a proposal for this one. Can you give it a look? thanks!

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - Supplier Address & VAT Number report fields are shown in settings but not shown in the report

What is the root cause of that problem?

The issue was in the report field filtering logic in two components:

App/src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx

Lines 92 to 112 in 1aa5d22

	return fields
	.filter((field) => field.target === report?.type)
	.filter((reportField) => !shouldHideSingleReportField(reportField))
	.sort(({orderWeight: firstOrderWeight}, {orderWeight: secondOrderWeight}) => firstOrderWeight - secondOrderWeight)
	.map((field): EnrichedPolicyReportField => {
	const fieldValue = field.value ?? field.defaultValue;
	const isFieldDisabled = isReportFieldDisabled(report, field, policy);
	const fieldKey = getReportFieldKey(field.fieldID);
	const violation = getFieldViolation(violations, field);
	const violationTranslation = getFieldViolationTranslation(field, violation);
	return {
	...field,
	fieldValue,
	isFieldDisabled,
	fieldKey,
	violation,
	violationTranslation,
	};
	});

App/src/components/ReportActionItem/MoneyReportView.tsx

Line 92 in 2308502

return fields.filter((field) => field.target === report?.type).sort(({orderWeight: firstOrderWeight}, {orderWeight: secondOrderWeight}) => firstOrderWeight - secondOrderWeight);

Both components were filtering report fields using a strict equality check: field.target === report?.type. This meant that:
Fields with target: 'invoice' (like "Supplier Address" and "VAT Number" for EUR workspaces) were only shown on invoice reports (type: 'invoice')

Thus, these fields were not shown on expense reports (type: 'expense'), even though they should be

What changes do you think we should make in order to solve the problem?

Update this filter logic to

          .filter((field) => {
                // Show fields that match the report type
                if (field.target === report?.type) {
                    return true;
                }
                // For expense reports, also show invoice-targeted fields (e.g., VAT Number, Supplier Address for EUR workspaces)
                // These fields are relevant for both expense and invoice reports
                if (report?.type === CONST.REPORT.TYPE.EXPENSE && field.target === CONST.REPORT.TYPE.INVOICE) {
                    return true;
                }
                return false;
            })

App/src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx

Line 93 in 1aa5d22

.filter((field) => field.target === report?.type)

Update this filter logic to

            .filter((field) => {
                // Show fields that match the report type
                if (field.target === report?.type) {
                    return true;
                }
                // For expense reports, also show invoice-targeted fields (e.g., VAT Number, Supplier Address for EUR workspaces)
                // These fields are relevant for both expense and invoice reports
                if (report?.type === CONST.REPORT.TYPE.EXPENSE && field.target === CONST.REPORT.TYPE.INVOICE) {
                    return true;
                }
                return false;
            })
            .sort(({orderWeight: firstOrderWeight}, {orderWeight: secondOrderWeight}) => firstOrderWeight - secondOrderWeight);

App/src/components/ReportActionItem/MoneyReportView.tsx

Line 92 in 2308502

return fields.filter((field) => field.target === report?.type).sort(({orderWeight: firstOrderWeight}, {orderWeight: secondOrderWeight}) => firstOrderWeight - secondOrderWeight);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.