-
Notifications
You must be signed in to change notification settings - Fork 78
Add font support for emojis #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one comment.
src/styleUtils.ts
Outdated
const FONT_FAMILY_EMOJI = Platform.select({ | ||
ios: 'Apple Color Emoji', | ||
android: 'Noto Color Emoji', | ||
default: 'Apple Color Emoji', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this will work on web across non-apple devices.
Also please mention |
Web tests are failing sometimes. Not sure why. There seems to be a problem on web. The emoji appears back in the composer after sending a message with an emoji. Screen.Recording.2025-04-16.at.8.06.55.PM.movI don't understand which changes for web are causing this. |
Was there ever a problem like this with any other style? |
@c3024 This problem exists on main too. See Expensify/App#59290 (comment) |
Thanks. I bashed my head yesterday trying to see how this PR could cause this bug. If I bump up the rnmarkdown version to 0.1.266, the bug happens on |
All review suggestions addressed. |
This PR causes the issue. I think we will revert it and try to fix it in a different way |
@VickyStash , yes, it's crashing on iOS for me too on version 0.1.264. |
@Skalakid Hm, I've just double-checked the conversation here, and it looks like the issue you are referring to existed on the E/App main as well. Though the bump PR wasn't even merged. So I don't think the problem was in my PR. |
@VickyStash Hmm, I'm not sure about that. I can't reproduce this bug on the latest main. Here I recorded 2 videos: with and without
|
@VickyStash @Skalakid could you share an update on the next steps to unblock merging this PR? |
Hey, I'm not really familiar with this issue/PR, I was just mentioned here cause my PR (which is now reverted) has been causing some issues during testing. |
@VickyStash Hey, as for the iOS crash during pasting, this has already been fixed in #668. |
Oh, can this PR be merged then? I've addressed the review suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Details
We are adding a custom emoji font for custom emoji support using Private User Area Unicodes.
App PR
Hybrid App PR
expensify-common PR
The current PR updates emoji style to support a font.
Related Issues
Expensify/App#54643
Manual Tests
With applying the App and Hybrid App PRs specified above,
customEmojiAndroid.mov
customEmojiiOS.mov
customEmojiChrome.mov
Linked PRs
App PR