Update ECS storage tests

Author: bornast

tests/ecs-service/index.test.ts

@@ -62,6 +62,7 @@ describe('EcsService component deployment', () => {
     assert.strictEqual(ecsService.name, ctx.config.minEcsName, 'Service should have the correct name');
     assert.strictEqual(ecsService.service.launchType, 'FARGATE', 'Service should use FARGATE launch type');
     assert.strictEqual(ecsService.service.desiredCount, 1, 'Service should have 1 desired task');
+    assert.strictEqual(ecsService.service.persistentStorage, undefined, 'Service should not have any storage');
   });
 
   it('should have a running ECS service with desired count of tasks', async () => {

tests/ecs-service/infrastructure/index.ts

@@ -26,7 +26,7 @@ const minimalEcsService = new studion.EcsService(`${appName}-min`, {
   cluster,
   vpc: project.vpc,
   containers: [sampleServiceContainer],
-  tags
+  tags,
 });
 
 const lbSecurityGroup = new aws.ec2.SecurityGroup(`${appName}-lb-sg`, {
@@ -145,6 +145,22 @@ const ecsServiceWithStorage = new studion.EcsService(`${appName}-storage`, {
   tags
 });
 
+const ecsServiceWithEmptyVolumes = new studion.EcsService(`${appName}-empty-vol`, {
+  cluster,
+  vpc: project.vpc,
+  containers: [sampleServiceContainer],
+  volumes: [],
+  tags
+});
+
+const ecsServiceWithOutputEmptyVolumes = new studion.EcsService(`${appName}-empty-otp-vol`, {
+  cluster,
+  vpc: project.vpc,
+  containers: [sampleServiceContainer],
+  volumes: pulumi.output([]),
+  tags
+});
+
 module.exports = {
   project,
   cluster,
@@ -153,5 +169,7 @@ module.exports = {
   lbUrl,
   ecsWithDiscovery,
   ecsServiceWithAutoscaling,
-  ecsServiceWithStorage
+  ecsServiceWithStorage,
+  ecsServiceWithEmptyVolumes,
+  ecsServiceWithOutputEmptyVolumes
 };

tests/ecs-service/persistent-storage.test.ts

@@ -215,4 +215,16 @@ export function testEcsServiceWithStorage(ctx: EcsTestContext) {
       numOfAttempts: 8,
     });
   });
+
+  it('should create ECS service when empty volumes array argument is passed', async () => {
+    const ecsService = ctx.outputs.ecsServiceWithEmptyVolumes.value;
+    assert.ok(ecsService, 'ECS Service should be defined');
+    assert.strictEqual(ecsService.service.persistentStorage, undefined, 'Service should not have any storage');
+  });
+
+  it('should create ECS service when empty output volumes array argument is passed', async () => {
+    const ecsService = ctx.outputs.ecsServiceWithOutputEmptyVolumes.value;
+    assert.ok(ecsService, 'ECS Service should be defined');
+    assert.strictEqual(ecsService.service.persistentStorage, undefined, 'Service should not have any storage');
+  });
 }