Commit b3d4262
committed
fix: align bench/build diagnostic assertions with actionable contract (#7975)
Several library tests asserted obsolete diagnostic wording and blocked the
Rust test gate, even though the exercised behavior already returns the
intended, more actionable diagnostics.
- Duplicate bench scenario tests expected the old validate.rs phrasing
("duplicate bench scenario id `x`" / "workload paths relative to the
bench root") and `details.id == "<scenario>"`. The current
`resolve_duplicate_scenario_ids` path emits the structured
`duplicate_scenario_id` diagnostic naming both discovered source paths
with `--path` / `--rig` remediation, and carries the diagnostic code in
`details.id`. Assertions now validate that contract (covers the two
listed tests plus selected_parse_still_rejects_selected_duplicate...,
which had the same stale wording).
- resolve_build_command_guides_unconfigured_components and
extension_guidance_hints_point_to_supported_paths both expect a
`scripts.build` component-owned-command hint that the guidance helper no
longer emitted. Restore the `scripts.<capability>` hint so the
unconfigured-component diagnostic actually points at the escape hatch
both tests document.
All bench parsing (45), extension (29), and the named build tests pass.1 parent 07653f7 commit b3d4262
2 files changed
Lines changed: 42 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1379 | 1379 | | |
1380 | 1380 | | |
1381 | 1381 | | |
| 1382 | + | |
| 1383 | + | |
| 1384 | + | |
| 1385 | + | |
1382 | 1386 | | |
1383 | | - | |
| 1387 | + | |
1384 | 1388 | | |
1385 | 1389 | | |
1386 | 1390 | | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
1387 | 1395 | | |
1388 | 1396 | | |
1389 | | - | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
1390 | 1406 | | |
1391 | 1407 | | |
1392 | | - | |
| 1408 | + | |
1393 | 1409 | | |
1394 | 1410 | | |
1395 | 1411 | | |
| |||
1459 | 1475 | | |
1460 | 1476 | | |
1461 | 1477 | | |
1462 | | - | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
1463 | 1486 | | |
1464 | 1487 | | |
1465 | 1488 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
235 | 249 | | |
236 | 250 | | |
| 251 | + | |
237 | 252 | | |
238 | 253 | | |
239 | 254 | | |
| |||
0 commit comments