fix(release): honor --skip-build-validation for package completeness

The package-completeness preflight (every tracked runtime file must be
present in the release ZIP) is a build-structure assertion, but it ran
unconditionally even when the operator passed --skip-build-validation.
The flag's documented contract is to bypass build-structure assertions
in both preflight.package and package, so the completeness check now
respects it via a should_validate_package_completeness() guard.

Fixes #8189

Author: chubes4

src/core/release/execution_dispatch.rs

@@ -115,11 +115,18 @@ pub(super) fn execute_release_plan_step(
                 context.options.skip_build_validation,
             )
             .and_then(|result| {
-                executor::package_preflight::validate_package_completeness(
-                    context.component,
-                    std::path::Path::new(&context.component.local_path),
-                    &context.state.artifacts,
-                )?;
+                // `--skip-build-validation` bypasses build-structure
+                // assertions in both `preflight.package` and `package`;
+                // package-completeness is one such assertion (#8189).
+                if executor::package_preflight::should_validate_package_completeness(
+                    context.options.skip_build_validation,
+                ) {
+                    executor::package_preflight::validate_package_completeness(
+                        context.component,
+                        std::path::Path::new(&context.component.local_path),
+                        &context.state.artifacts,
+                    )?;
+                }
                 Ok(result)
             })
             .unwrap_or_else(|err| failed_result("package", "package", err)),

src/core/release/executor/package_preflight.rs

@@ -15,6 +15,17 @@ pub(crate) fn run_package_preflight(component_local_path: &str) -> Result<()> {
     super::lockfile_guard::guard_local_file_dependencies(component_path)
 }
 
+/// Whether the package-completeness structure assertion should run.
+///
+/// `--skip-build-validation` is documented to bypass build-structure
+/// assertions in both `preflight.package` and `package`. Package-completeness
+/// (every tracked runtime file present in the ZIP) is such a structure
+/// assertion, so an explicit override must skip it rather than fail closed
+/// (#8189).
+pub(crate) fn should_validate_package_completeness(skip_build_validation: bool) -> bool {
+    !skip_build_validation
+}
+
 /// Confirm that the durable artifacts produced by the final package step
 /// include every tracked runtime file in the configured release scope.
 pub(crate) fn validate_package_completeness(
@@ -300,6 +311,16 @@ mod tests {
             .expect("excluded runtime file should not fail");
     }
 
+    #[test]
+    fn skip_build_validation_bypasses_package_completeness() {
+        // #8189: when the operator passes --skip-build-validation, the
+        // package-completeness structure assertion must not run, matching the
+        // documented CLI contract.
+        assert!(!should_validate_package_completeness(true));
+        // Default release behavior still enforces completeness.
+        assert!(should_validate_package_completeness(false));
+    }
+
     fn run_git(repo: &Path, args: &[&str]) {
         let output = Command::new("git")
             .args(args)