Fix bug with range methods

Author: Ezibenroc

pyroaring/abstract_bitmap.pxi

@@ -148,6 +148,10 @@ cdef class AbstractBitMap:
         >>> bm.contains_range(8, 12)
         False
         """
+        if range_end <= range_start or range_end == 0 or range_start >= 2**32:
+            return True  # empty range
+        if range_end >= 2**32:
+            range_end = 2**32
         return croaring.roaring_bitmap_contains_range(self._c_bitmap, range_start, range_end)
 
     cdef compute_hash(self):

pyroaring/bitmap.pxi

@@ -138,6 +138,10 @@ cdef class BitMap(AbstractBitMap):
         >>> bm
         BitMap([5, 6, 7, 8])
         """
+        if range_end <= range_start or range_end == 0 or range_start >= 2**32:
+            return
+        if range_end >= 2**32:
+            range_end = 2**32
         croaring.roaring_bitmap_add_range(self._c_bitmap, range_start, range_end)
 
     def remove_range(self, uint64_t range_start, uint64_t range_end):
@@ -149,4 +153,8 @@ cdef class BitMap(AbstractBitMap):
         >>> bm
         BitMap([5, 9, 10])
         """
+        if range_end <= range_start or range_end == 0 or range_start >= 2**32:
+            return
+        if range_end >= 2**32:
+            range_end = 2**32
         croaring.roaring_bitmap_remove_range(self._c_bitmap, range_start, range_end)

test.py

@@ -33,6 +33,7 @@
 
 uint18 = st.integers(min_value=0, max_value=2**18)
 uint32 = st.integers(min_value=0, max_value=2**32-1)
+uint64 = st.integers(min_value=0, max_value=2**64-1)
 integer = st.integers(min_value=0, max_value=2**31-1)
 
 range_max_size = 2**18
@@ -448,6 +449,17 @@ def test_add_remove_range(self, values, cow, start, end):
         self.assertFalse(bm.contains_range(start, end))
         self.assertEqual(bm.intersection_cardinality(BitMap(range(start, end), copy_on_write=cow)), 0)
 
+    @given(hyp_collection, st.booleans(), uint64, uint64)
+    def test_large_values(self, values, cow, start, end):
+        st.assume(start >= 2**32 and end >= 2**32)
+        bm = BitMap(values, copy_on_write=cow)
+        original = BitMap(bm)
+        bm.add_range(start, end)
+        self.assertEqual(bm, original)
+        bm.remove_range(start, end)
+        self.assertEqual(bm, original)
+        self.assertTrue(bm.contains_range(start, end))
+
 
 class CardinalityTest(Util):