Repository navigation
Conversation
With several -f files that use `extends`, the extended project was inserted at the file's index in the -f list. Each earlier `extends` adds a project, so later bases landed too early and earlier files overrode them: `-f a -f b` merged as c, d, a, b instead of c, a, d, b. Insert at the number of projects loaded so far instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



With several
-ffiles that useextends,Loadinserted each extended project at the file's index in the-flist, but earlierextendshad already added projects there, so a later file's base was merged before the earlier files (-f a -f bwith a extending c and b extending d merged as c, d, a, b instead of c, a, d, b). It now inserts atlen(opts.projects), so each base lands right before the file that extends it, nested bases still go before their parent, and the order only changes when an earlier-ffile usesextends.TestLoad_MultipleFilesWithExtendschecks the merge order and merged values for two extending files, a plain file first, the reversed order and a nested base; it fails on main and passes with the fix.go test -race ./src/...and golangci-lint pass.Fixes #593