Skip to content

Conversation

@shnizzedy
Copy link
Member

Related to

Related to dockerdocs: LegacyKeyValueFormat

Technical details

Replaces regex

(LABEL [a-zA-Z\.]*)( )

with

$1=

in all the Dockerfiles (i.e., every LABEL key value becomes LABEL key=value).

Screenshots

before this PR

Annotations: LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

after this PR

no build check annotations

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy requested a review from a team March 10, 2025 19:14
@shnizzedy shnizzedy self-assigned this Mar 10, 2025
@shnizzedy shnizzedy moved this to 👀 In review in C-PAC Development Mar 10, 2025
@shnizzedy shnizzedy added this to the 1.8.8 release milestone Mar 10, 2025
Copy link
Contributor

@birajstha birajstha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@shnizzedy shnizzedy merged commit afe65f5 into develop Mar 13, 2025
25 checks passed
@shnizzedy shnizzedy deleted the LegacyKeyValueFormat branch March 13, 2025 20:55
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in C-PAC Development Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants