-
-
Notifications
You must be signed in to change notification settings - Fork 41
Freesurfer ingress reorient #2199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2f514ca
with precommit
birajstha 0b2a017
Merge branch 'develop' into fs_ingress_reorient
birajstha 7371e15
correcting the function doc-string
birajstha 325deb5
Update CPAC/pipeline/engine.py
birajstha 784089c
Merge branch 'develop' into fs_ingress_reorient
birajstha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These
C-PAC/CPAC/pipeline/engine.py
Lines 2014 to 2018 in 325deb5
C-PAC/CPAC/pipeline/engine.py
Lines 2019 to 2035 in 325deb5
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question ! It looks like all

pipeline-fs_hemi*are not used in CPAC but are only ingressed.I am not sure about
pipeline-fs_xfm. It probably needs reorient/resample as well.I will loop in @sgiavasis here for further clarification.
Steve, do we need to resample this xfm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've had extensive conversation on this off of GitHub, but going forward from here, let's resolve whatever requested changes there are and merge this.
For the reorient for running Freesurfer as part of the C-PAC pipeline, let's open a separate but related PR for it, as it will be an extension of this one but different.
I'd like to get some runs going with this change for now (since it will be ingressed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am adding this below for documentation purposes.
Tested applying the
xfmmentioned above towmparcfromFreesurfer native orientationand
2. reoriented one from this PR
There appears to be no difference in the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So reorienting only
.mgzfiles.