Skip to content

Conversation

@birajstha
Copy link
Contributor

@birajstha birajstha commented Apr 4, 2025

Fixes

Fixes #2206 by @birajstha
Related to #2047
Details are discussed here in the slack thread.

Description

Adds a specific switch for restore_t1w_intensity

Technical details

Tests

Tested running test-config.
It completed fine after the fix.

#!/usr/bin/bash
#SBATCH -N 1
#SBATCH -p RM-shared
#SBATCH -t 50:00:00

MED=/ocean/projects/med250004p
DATA=/ocean/projects/med250004p/bshresth/projects/fs_orientation/data
OUTPUT=/ocean/projects/med250004p/bshresth/projects/fs_orientation/output2
IMAGE=/ocean/projects/med250004p/bshresth/projects/fs_orientation/cpac_nightly.sif

PIPELINE=/ocean/projects/med250004p/bshresth/projects/fs_orientation/configs/ingress_fs.yml


subject=sub-PA001


repo=/ocean/projects/med250004p/bshresth/projects/fs_orientation/C-PAC
singularity run \
    -B $MED \
    -B $DATA:$DATA \
    -B $OUTPUT:$OUTPUT $IMAGE $DATA $OUTPUT test-config \
    --num_ants_threads 5 \
    --skip_bids_validator \
    --n_cpus 2 \
    --mem_gb 50 \
    --pipeline_file $PIPELINE \
    --participant_label $subject

Screenshots

Before
image

After the fix
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@birajstha birajstha requested a review from a team April 4, 2025 19:28
Copy link
Collaborator

@sgiavasis sgiavasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!!

@sgiavasis sgiavasis merged commit 2567db5 into develop Apr 4, 2025
27 checks passed
@birajstha birajstha deleted the fix/restore-brain-intensity-abcd branch April 4, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

🐛 when using FreeSurfer-ABCD for brain masking, correct_restore_brain_intensity_abcd turns on automatically

3 participants