-
-
Notifications
You must be signed in to change notification settings - Fork 41
🐛 Restore header to censors.tsv
#2228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem with the censors shifting by 1 place in Tproject and I think was resolved when @sgiavasis removed the header. I guess we could add the header while saving but skip it while loading?
Ref #2228 (comment), #2228 (comment) Co-authored-by: Biraj Shrestha <[email protected]>
Ref #2228 (comment), #2228 (comment) Co-authored-by: Biraj Shrestha <[email protected]>
aed8093 to
421d868
Compare
birajstha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎆
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2228 +/- ##
=========================================
+ Coverage 27.2% 27.3% +0.1%
=========================================
Files 228 228
Lines 25830 25859 +29
Branches 4062 4066 +4
=========================================
+ Hits 7025 7054 +29
Misses 18188 18188
Partials 617 617
🚀 New features to boost your workflow:
|

Fixes
Fixes #2181 by @sgiavasis
Related to #2225 by @shnizzedy
Description
Restores the header
censorto
censors.tsv. Without it, 3dTProject was reading the first row as the header, resulting in 1-too-few timepoints (and the timepoints being off by one).Checklist
Update index.md).developbranch of the repository.Developer Certificate of Origin
Developer Certificate of Origin