Skip to content

Conversation

@shnizzedy
Copy link
Member

@shnizzedy shnizzedy commented Apr 28, 2025

Fixes

Fixes #2181 by @sgiavasis
Related to #2225 by @shnizzedy

Description

Restores the header

censor

to censors.tsv. Without it, 3dTProject was reading the first row as the header, resulting in 1-too-few timepoints (and the timepoints being off by one).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shnizzedy shnizzedy added bug develop issue on `develop` branch labels Apr 28, 2025
@shnizzedy shnizzedy added this to the 1.8.8 release milestone Apr 28, 2025
@shnizzedy shnizzedy requested a review from a team April 28, 2025 20:39
@shnizzedy shnizzedy self-assigned this Apr 28, 2025
Copy link
Contributor

@birajstha birajstha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a problem with the censors shifting by 1 place in Tproject and I think was resolved when @sgiavasis removed the header. I guess we could add the header while saving but skip it while loading?

@shnizzedy
Copy link
Member Author

The integration test is only failing because the cluster is down:
Bridges-2: Due to severe weather in the Pittsburgh region, our machine room is currently offline. We’re working to restore services as soon as possible. Thank you for your patience.

Copy link
Contributor

@birajstha birajstha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.3%. Comparing base (9248007) to head (421d868).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
CPAC/nuisance/nuisance.py 0.0% 3 Missing ⚠️
CPAC/nuisance/tests/test_utils.py 90.0% 2 Missing ⚠️
CPAC/nuisance/utils/utils.py 93.3% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2228     +/-   ##
=========================================
+ Coverage     27.2%   27.3%   +0.1%     
=========================================
  Files          228     228             
  Lines        25830   25859     +29     
  Branches      4062    4066      +4     
=========================================
+ Hits          7025    7054     +29     
  Misses       18188   18188             
  Partials       617     617             
Files with missing lines Coverage Δ
CPAC/nuisance/utils/__init__.py 100.0% <ø> (ø)
CPAC/nuisance/utils/utils.py 36.8% <93.3%> (+2.6%) ⬆️
CPAC/nuisance/tests/test_utils.py 73.7% <90.0%> (+17.2%) ⬆️
CPAC/nuisance/nuisance.py 24.1% <0.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shnizzedy shnizzedy merged commit a08f8c5 into develop May 5, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug develop issue on `develop` branch

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants