🐛 Fix TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType'

[shnizzedy]

Fixes

Fixes

C-PAC failed to start
Traceback (most recent call last):
  File "/code/CPAC/pipeline/cpac_runner.py", line 653, in run
    exitcode = run_workflow(
  File "/code/CPAC/pipeline/cpac_pipeline.py", line 806, in run_workflow
    resource_report(cb_log_filename, num_cores_per_sub, WFLOGGER)
  File "/code/CPAC/utils/monitoring/draw_gantt_chart.py", line 592, in resource_report
    generate_gantt_chart(callback_log, num_cores)
  File "/code/CPAC/utils/monitoring/draw_gantt_chart.py", line 405, in generate_gantt_chart
    node["duration"] = (node["finish"] - node["start"]).total_seconds()
TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType'

Description

I noticed 1.8.8.dev runs having fake-out failedToStart.logs with the above error, trying to set durations on nodes that hadn't yet started.

Technical details

Checks that there's a start and a finish before setting a duration.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I updated the changelog.
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[birajstha]

🎊, I guess this one fixes CPAC stalling with 0/ running.
I had seen few of them in my runs with 1.8.8 too.

[shnizzedy]

I guess this one fixes CPAC stalling with 0/ running.

I don't think these were actually failing to start; I think they were just incorrectly logging that they were failing to start