Skip to content

Conversation

@birajstha
Copy link
Contributor

Fixes

Fixes #2262 by @sgiavasis

Description

Removes desc-head_T1w output from brain_extraction nodeblock.
Tested running test-config with all pre-config options and WF was built successfully.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I updated the changelog.
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@birajstha birajstha linked an issue Jul 7, 2025 that may be closed by this pull request
15 tasks
@birajstha birajstha requested a review from a team July 7, 2025 20:47
@birajstha birajstha self-assigned this Jul 7, 2025
@birajstha birajstha moved this to 👀 In review in C-PAC Development Jul 7, 2025
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.8%. Comparing base (c6abb3e) to head (404cfb7).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2264   +/-   ##
=======================================
  Coverage     33.8%   33.8%           
=======================================
  Files          233     233           
  Lines        26328   26328           
  Branches      4135    4135           
=======================================
  Hits          8903    8903           
  Misses       16696   16696           
  Partials       729     729           
Files with missing lines Coverage Δ
CPAC/anat_preproc/anat_preproc.py 38.2% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@shnizzedy shnizzedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sgiavasis sgiavasis merged commit 2d9b244 into develop Jul 28, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in C-PAC Development Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

🐛 No need to write out desc-head_T1w in brain_extraction

4 participants