-
-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
Description
Related problem
Right now, cpac read-only binds the directory containing a user-provided data config file
cpac/src/cpac/backends/platform.py
Lines 214 to 219 in 9be16ca
| dc_dir = os.path.dirname(kwargs['data_config_file']) | |
| self._bind_volume(dc_dir, dc_dir, 'r') | |
| locals_from_data_config = Locals_to_bind() | |
| locals_from_data_config.from_config_file( | |
| kwargs['data_config_file'] | |
| ) |
/cpax_forum: Re: RuntimeError)
Proposed feature
Just bind the data config file itself, something like
dc_file = os.path.abspath(kwargs['data_config_file'])
self._bind_volume(dc_file, dc_file, 'r')
locals_from_data_config = Locals_to_bind()
locals_from_data_config.from_config_file(
dc_file
) Acceptance criteria
- data config file binds read-only but doesn't (necessarily) bind its parent directory read-only
Alternatives
No response
Additional context
Maybe also bind individual files from the data config instead of their parent directories too?
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
No status