[WoW64]: LEGO Star Wars/Star Wars Battlefront: Various SEH crashes in retail installers

[chadmed]

Retail CD/DVD copies of both games, launching the installer(s) results in various SEH errors in WINE with FEX 2510 DLLs. This is a regression from 2508 and 2509 where WoW64 worked. Tested with upstream WINE 10.15 (known working with FEX 2507), WINE 10.17, and the upstream-arm64ec branch from bylaws/wine. All tests done inside and outside of muvm. Also tested with just about every possible FEXConfig combination.

This does not seem relegated to just these two installers, but they're the ones I have on hand to test and ones I know worked previously.

To Reproduce
Steps to reproduce the behavior:

1. Install some flavour of WINE and FEX 2510 DLLs.
2. Attempt to launch the LEGO Star Wars or Star Wars Battlefront installers. In the case of the latter, LaunchBF.exe will open to a blank white screen with FEX 2507 but this is a WINE bug. With FEX 2510, you get the SEH nonsense.
3. Observe the installers crash with SEH-related error messages coming from WINE.

Expected behavior
The installers should run without crashing.

Screenshots and Video

Log above is from a clean wineprefix spun up by bylaws/wine trying to launch the SWBF installer. All tested WINE versions behave identically with FEX 2510.

System information:

• OS: Gentoo ~arm64
• CPU/SoC: Apple M2 Max
• Video driver version: Upstream Mesa 25.2.6
• RootFS used: Gentoo FEX rootfs
• FEX version: Upstream FEX-2510 as tagged
• Thunks Enabled: No

Additional context

• Is this an x86 or x86-64 game: Both titles are x86-only
• Does this reproduce on AArch64 with Radeon/Intel/Nvidia: Untested
• Is this a Vulkan game: By way of x86 DXVK, yes. But we don't get that far.
  • If Yes, What is your Vulkan driver: Honeykrisp

Output of wineserver -df 2>&1 | tee -a winelog.log & wine 'D:\setup.exe' 2&>1 | tee -a winelog.log: https://0x0.st/KL_7.log

[chadmed]

FEX 2508 also exhibits this behaviour.

[neobrain]

Retail CD/DVD copies of both games, launching the installer(s) results in various SEH errors in WINE with FEX 2510 DLLs. This is a regression from 2508 and 2509 where WoW64 worked. Tested with upstream WINE 10.15 (known working with FEX 2507), WINE 10.17, and the upstream-arm64ec branch from bylaws/wine. All tests done inside and outside of muvm. Also tested with just about every possible FEXConfig combination.

FEX 2508 also exhibits this behaviour.

Do I understand correctly that you're reporting the installer was working fine in FEX 2507 and is broken since 2508, irrespective of the Wine version used?

This may be a bit tough to debug if it doesn't reproduce on the Steam build of the game. Any chance you could narrow it down to a specific git commit between 2507 and 2508? If building is an issue, our woa nix helpers in https://github.com/FEX-Emu/FEX/tree/main/Data/nix might help.

[chadmed]

Do I understand correctly that you're reporting the installer was working fine in FEX 2507 and is broken since 2508, irrespective of the Wine version used?

Indeed. WINEs 10.13 to 10.18 (with WoW64 enabled and ARM64EC _dis_abled) launch the installers (and games for that matter) with no issues on FEX-2507, but not 2508. Both within and without muvm.

Some odd interdependency in FEXCore is preventing me from building a few commits and I'm too tired to figure it out right now, but I've narrowed down the list of suspects to these commits:

2e5c628
d0af858
261df26
31903d0
21865d0
96bd6ce
14eed89
46bc8e4
6eaaab8

[chadmed]

#4474 (comment)

May regress a few (very old) 32-bit programs with WOW64 - needs some wine/fex patches for some new API surface and I didn't run into issues with anything I tested so I think that's fine to do after

Famous last words :)

[neobrain]

Some odd interdependency in FEXCore is preventing me from building a few commits and I'm too tired to figure it out right now, but I've narrowed down the list of suspects to these commits:

Thanks, that helps a lot!

Perhaps @bylaws could take a look at the regression?