Handle missing direct-read registry objects

Author: snissn

src/demo/tokenhost-wrapper.mjs

@@ -155,7 +155,8 @@ export function createTokenHostRegistryDirectReadAdapter({
       readContract(reads.receiptPayer),
     ]);
     const object = normalizeRegistryStorageObject(objectResult);
-    const normalizedObjectId = object.objectId === "0" ? decimalString(objectId) : object.objectId;
+    if (isMissingRegistryObject(object)) return null;
+    const normalizedObjectId = object.objectId;
 
     return {
       objectId: normalizedObjectId,
@@ -186,7 +187,9 @@ export function createTokenHostRegistryDirectReadAdapter({
         ),
     });
     const ids = Array.from(page.values, decimalString);
-    const objects = await mapWithConcurrency(ids, maxDetailConcurrency, readObjectDetails);
+    const objects = (
+      await mapWithConcurrency(ids, maxDetailConcurrency, readObjectDetails)
+    ).filter(Boolean);
 
     return {
       sourceOfTruth: DIRECT_READ_SOURCE,
@@ -384,6 +387,7 @@ export function createTokenHostRegistryDirectReadAdapter({
 
   async function mergeObjectDetail(model, objectId) {
     const row = await readObjectDetails(objectId);
+    if (!row) return;
     model.objects[row.objectId] = row.object;
     model.copyReceipts[row.objectId] = row.copyReceipts;
     model.receiptPayers[row.objectId] = row.receiptPayer;
@@ -398,6 +402,7 @@ export function createTokenHostRegistryDirectReadAdapter({
         includeTerminal: options.includeTerminal ?? includeTerminal,
       });
       for (const row of result.objects) {
+        if (!row) continue;
         model.objects[row.objectId] = row.object;
         model.copyReceipts[row.objectId] = row.copyReceipts;
         model.receiptPayers[row.objectId] = row.receiptPayer;
@@ -763,6 +768,10 @@ function currentUnixSeconds() {
   return Math.floor(Date.now() / 1000);
 }
 
+function isMissingRegistryObject(object) {
+  return object.objectId === "0";
+}
+
 function decimalString(value) {
   return BigInt(value).toString();
 }

test/tokenhost-direct-reads.test.mjs

@@ -160,6 +160,20 @@ test("Token Host direct read adapter honors admin route hints", async () => {
     "getCopyReceipts",
     "receiptPayer",
   ]);
+
+  calls.length = 0;
+  const missingObject = await api.handle({
+    method: "GET",
+    path: "/admin/storage/objects/999",
+    headers: {},
+  });
+  assert.equal(missingObject.status, 404);
+  assert.equal(missingObject.body.error.code, "admin_object_not_found");
+  assert.deepEqual(calls.map((call) => call.functionName), [
+    "getStorageObject",
+    "getCopyReceipts",
+    "receiptPayer",
+  ]);
 });
 
 test("Token Host direct read adapter defaults admin time for coordinator expiry checks", async () => {
@@ -313,7 +327,7 @@ function createRegistryFixtureClient({ staleActiveCursor, calls } = {}) {
         case "listRelayerAddresses":
           return offsetPage([RELAYER], args[0], args[1]);
         case "getStorageObject":
-          return objects.get(String(args[0]));
+          return objects.get(String(args[0])) ?? zeroStorageObject();
         case "getAccountUsage":
           return usage.get(args[0]);
         case "getCopyReceipts":
@@ -381,6 +395,31 @@ function offsetPage(values, offset, limit) {
   return values.slice(Number(offset), Number(offset) + Number(limit));
 }
 
+function zeroStorageObject() {
+  return {
+    objectId: 0n,
+    accountId: hex32("00"),
+    user: ZERO_ADDRESS,
+    idempotencyKey: hex32("00"),
+    contentHash: hex32("00"),
+    metadataHash: hex32("00"),
+    pieceCidHash: hex32("00"),
+    size: 0n,
+    requestedCopies: 0,
+    completedCopies: 0,
+    withCDN: false,
+    maxCost: 0n,
+    reservedCost: 0n,
+    actualCost: 0n,
+    status: 0,
+    coordinator: ZERO_ADDRESS,
+    requestExpiresAt: 0n,
+    createdAt: 0n,
+    updatedAt: 0n,
+    receiptHash: hex32("00"),
+  };
+}
+
 function hex32(byte) {
   return `0x${byte.padStart(64, "0")}`;
 }