Skip to content

Commit c8a482b

Browse files
committed
CI: Remove windows-2019 from workflows as it has been removed.
This prevents use of CI for CUDA < 12.4 on windows, due to an arbitrary change by microsoft in MSVC 1941 / VS2022 17.11. There may be (unstable) workarounds possible with recent enough CMake...
1 parent 8cbb120 commit c8a482b

3 files changed

Lines changed: 19 additions & 42 deletions

File tree

.github/workflows/Draft-Release.yml

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ defaults:
2828
# + Wheel producing manylinux builds
2929
# + CUDA 11.2 and 12.0, py 3.8-3.12, vis on/off, py only.
3030
# + Wheel producing Windows builds
31-
# + CUDA 11.2 and 12.0, py 3.8-3.12, vis on/off, py only.
31+
# + CUDA 12.4 (due to visual studio), py 3.8-3.12, vis on/off, py only.
3232
# + Draft github release workflow.
3333

3434
jobs:
@@ -186,18 +186,11 @@ jobs:
186186
cuda_arch: "50-real;90-real;90-virtual"
187187
hostcxx: "Visual Studio 17 2022"
188188
os: windows-2022
189-
- cuda: "12.0.0"
189+
# CUDA 12.4 is the oldest CUDA supported by recent visual studio 2022 versions :(
190+
- cuda: "12.4.0"
190191
cuda_arch: "50-real;90-real;90-virtual"
191-
hostcxx: "Visual Studio 16 2019"
192-
os: windows-2019
193-
- cuda: "11.8.0"
194-
cuda_arch: "35-real;90-real;90-virtual"
195-
hostcxx: "Visual Studio 16 2019"
196-
os: windows-2019
197-
- cuda: "11.2.2"
198-
cuda_arch: "35-real;80-real;80-virtual"
199-
hostcxx: "Visual Studio 16 2019"
200-
os: windows-2019
192+
hostcxx: "Visual Studio 17 2022"
193+
os: windows-2022
201194
python:
202195
- "3.8"
203196
config:
@@ -481,14 +474,11 @@ jobs:
481474
# optional exclude: can be partial, include: must be specific
482475
matrix:
483476
cudacxx:
484-
- cuda: "12.0.0"
477+
# VS2022 on required 12.4, which prevents older wheel building.
478+
- cuda: "12.4.0"
485479
cuda_arch: "50-real;60-real;70-real;80-real;90-real;90-virtual"
486-
hostcxx: "Visual Studio 16 2019"
487-
os: windows-2019
488-
- cuda: "11.2.2"
489-
cuda_arch: "35-real;50-real;60-real;70-real;80-real;80-virtual"
490-
hostcxx: "Visual Studio 16 2019"
491-
os: windows-2019
480+
hostcxx: "Visual Studio 17 2022"
481+
os: windows-2022
492482
python:
493483
- "3.12"
494484
- "3.11"

.github/workflows/Windows-Tests.yml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,11 @@ jobs:
2727
cuda_arch: "50"
2828
hostcxx: "Visual Studio 17 2022"
2929
os: windows-2022
30-
- cuda: "12.0.0"
30+
# CUDA 12.4 is the oldest CUDA supported by recent visual studio 2022 versions :(
31+
- cuda: "12.4.0"
3132
cuda_arch: "50"
32-
hostcxx: "Visual Studio 16 2019"
33-
os: windows-2019
34-
- cuda: "11.8.0"
35-
cuda_arch: "35"
36-
hostcxx: "Visual Studio 16 2019"
37-
os: windows-2019
38-
- cuda: "11.2.2"
39-
cuda_arch: "35"
40-
hostcxx: "Visual Studio 16 2019"
41-
os: windows-2019
33+
hostcxx: "Visual Studio 17 2022"
34+
os: windows-2022
4235
config:
4336
- name: "Release"
4437
config: "Release"

.github/workflows/Windows.yml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,19 +32,13 @@ jobs:
3232
- cuda: "12.6.0"
3333
cuda_arch: "50"
3434
hostcxx: "Visual Studio 17 2022"
35-
os: windows-2022
36-
- cuda: "12.0.0"
35+
os: windows-2025
36+
# CUDA 12.4 is the oldest CUDA supported by recent visual studio 2022 versions :(
37+
- cuda: "12.4.0"
3738
cuda_arch: "50"
38-
hostcxx: "Visual Studio 16 2019"
39-
os: windows-2019
40-
- cuda: "11.8.0"
41-
cuda_arch: "35"
42-
hostcxx: "Visual Studio 16 2019"
43-
os: windows-2019
44-
- cuda: "11.2.2"
45-
cuda_arch: "35"
46-
hostcxx: "Visual Studio 16 2019"
47-
os: windows-2019
39+
hostcxx: "Visual Studio 17 2022"
40+
os: windows-2022
41+
4842
python:
4943
- "3.12"
5044
config:

0 commit comments

Comments
 (0)