Skip to content

Commit fb72dbc

Browse files
committed
Warnings: Fix GCC 13 pessimizing-move warnings
error: moving a temporary object prevents copy elision [-Werror=pessimizing-move]
1 parent e636f01 commit fb72dbc

7 files changed

Lines changed: 13 additions & 13 deletions

File tree

src/flamegpu/runtime/messaging/MessageArray.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,9 @@ void MessageArray::CUDAModelHandler::buildIndex(detail::CUDAScatter &scatter, un
105105
/// CDescription
106106
/// </summary>
107107
MessageArray::CDescription::CDescription(std::shared_ptr<Data> data)
108-
: MessageBruteForce::CDescription(std::move(std::static_pointer_cast<MessageBruteForce::Data>(data))) { }
108+
: MessageBruteForce::CDescription(std::static_pointer_cast<MessageBruteForce::Data>(data)) { }
109109
MessageArray::CDescription::CDescription(std::shared_ptr<const Data> data)
110-
: CDescription(std::move(std::const_pointer_cast<Data>(data))) { }
110+
: CDescription(std::const_pointer_cast<Data>(data)) { }
111111

112112
bool MessageArray::CDescription::operator==(const CDescription& rhs) const {
113113
return *this->message == *rhs.message; // Compare content is functionally the same

src/flamegpu/runtime/messaging/MessageArray2D.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ void MessageArray2D::CUDAModelHandler::buildIndex(detail::CUDAScatter &scatter,
106106
/// CDescription
107107
/// </summary>
108108
MessageArray2D::CDescription::CDescription(std::shared_ptr<Data> data)
109-
: MessageBruteForce::CDescription(std::move(std::static_pointer_cast<MessageBruteForce::Data>(data))) { }
109+
: MessageBruteForce::CDescription(std::static_pointer_cast<MessageBruteForce::Data>(data)) { }
110110
MessageArray2D::CDescription::CDescription(std::shared_ptr<const Data> data)
111-
: CDescription(std::move(std::const_pointer_cast<Data>(data))) { }
111+
: CDescription(std::const_pointer_cast<Data>(data)) { }
112112

113113
bool MessageArray2D::CDescription::operator==(const CDescription& rhs) const {
114114
return *this->message == *rhs.message; // Compare content is functionally the same

src/flamegpu/runtime/messaging/MessageArray3D.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ void MessageArray3D::CUDAModelHandler::buildIndex(detail::CUDAScatter &scatter,
106106
/// CDescription
107107
/// </summary>
108108
MessageArray3D::CDescription::CDescription(std::shared_ptr<Data> data)
109-
: MessageBruteForce::CDescription(std::move(std::static_pointer_cast<MessageBruteForce::Data>(data))) { }
109+
: MessageBruteForce::CDescription(std::static_pointer_cast<MessageBruteForce::Data>(data)) { }
110110
MessageArray3D::CDescription::CDescription(std::shared_ptr<const Data> data)
111-
: CDescription(std::move(std::const_pointer_cast<Data>(data))) { }
111+
: CDescription(std::const_pointer_cast<Data>(data)) { }
112112

113113
bool MessageArray3D::CDescription::operator==(const CDescription& rhs) const {
114114
return *this->message == *rhs.message; // Compare content is functionally the same

src/flamegpu/runtime/messaging/MessageBruteForce.cu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ std::type_index MessageBruteForce::Data::getType() const { return std::type_inde
100100
MessageBruteForce::CDescription::CDescription(std::shared_ptr<Data> data)
101101
: message(std::move(data)) { }
102102
MessageBruteForce::CDescription::CDescription(std::shared_ptr<const Data> data)
103-
: message(std::move(std::const_pointer_cast<Data>(data))) { }
103+
: message(std::const_pointer_cast<Data>(data)) { }
104104

105105
bool MessageBruteForce::CDescription::operator==(const CDescription& rhs) const {
106106
return *this->message == *rhs.message; // Compare content is functionally the same

src/flamegpu/runtime/messaging/MessageBucket.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,9 @@ void MessageBucket::CUDAModelHandler::resizeKeysVals(const unsigned int newSize)
165165
/// CDescription
166166
/// </summary>
167167
MessageBucket::CDescription::CDescription(std::shared_ptr<Data> data)
168-
: MessageBruteForce::CDescription(std::move(std::static_pointer_cast<MessageBruteForce::Data>(data))) { }
168+
: MessageBruteForce::CDescription(std::static_pointer_cast<MessageBruteForce::Data>(data)) { }
169169
MessageBucket::CDescription::CDescription(std::shared_ptr<const Data> data)
170-
: CDescription(std::move(std::const_pointer_cast<Data>(data))) { }
170+
: CDescription(std::const_pointer_cast<Data>(data)) { }
171171

172172
bool MessageBucket::CDescription::operator==(const CDescription& rhs) const {
173173
return *this->message == *rhs.message; // Compare content is functionally the same

src/flamegpu/runtime/messaging/MessageSpatial2D.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,9 @@ void MessageSpatial2D::CUDAModelHandler::resizeKeysVals(const unsigned int newSi
171171
/// CDescription
172172
/// </summary>
173173
MessageSpatial2D::CDescription::CDescription(std::shared_ptr<Data> data)
174-
: MessageBruteForce::CDescription(std::move(std::static_pointer_cast<MessageBruteForce::Data>(data))) { }
174+
: MessageBruteForce::CDescription(std::static_pointer_cast<MessageBruteForce::Data>(data)) { }
175175
MessageSpatial2D::CDescription::CDescription(std::shared_ptr<const Data> data)
176-
: CDescription(std::move(std::const_pointer_cast<Data>(data))) { }
176+
: CDescription(std::const_pointer_cast<Data>(data)) { }
177177

178178
bool MessageSpatial2D::CDescription::operator==(const CDescription& rhs) const {
179179
return *this->message == *rhs.message; // Compare content is functionally the same

src/flamegpu/runtime/messaging/MessageSpatial3D.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,9 @@ void MessageSpatial3D::CUDAModelHandler::resizeKeysVals(const unsigned int newSi
170170
/// CDescription
171171
/// </summary>
172172
MessageSpatial3D::CDescription::CDescription(std::shared_ptr<Data> data)
173-
: MessageSpatial2D::CDescription(std::move(std::static_pointer_cast<MessageSpatial2D::Data>(data))) { }
173+
: MessageSpatial2D::CDescription(std::static_pointer_cast<MessageSpatial2D::Data>(data)) { }
174174
MessageSpatial3D::CDescription::CDescription(std::shared_ptr<const Data> data)
175-
: CDescription(std::move(std::const_pointer_cast<Data>(data))) { }
175+
: CDescription(std::const_pointer_cast<Data>(data)) { }
176176

177177
bool MessageSpatial3D::CDescription::operator==(const CDescription& rhs) const {
178178
return *this->message == *rhs.message; // Compare content is functionally the same

0 commit comments

Comments
 (0)