Merge pull request #1370 from chhsiao1981/createFeedWithFilepath

simplify createFeedWithFilepath

Author: chhsiao1981

src/api/serverApi.ts

@@ -1,7 +1,7 @@
 import config from "config";
 import type { ReadonlyNonEmptyArray } from "fp-ts/lib/ReadonlyNonEmptyArray";
 import YAML from "yaml";
-import api, { type ApiResult } from "./api";
+import api from "./api";
 import type { PACSqueryCore } from "./pfdcm";
 import { PACSqueryCoreToJSON } from "./pfdcm/generated";
 import type {
@@ -90,24 +90,13 @@ export const createWorkflow = (
     },
   });
 
-type createFeedWithFilepathProp = {
-  filepath: string;
-  theName: string;
-  tags: string[];
-  patientID?: string;
-  modality?: string;
-  studyDate?: string;
-  isPublic?: boolean;
-};
-export const createFeedWithFilepath = async ({
-  filepath,
-  theName,
-  tags,
-  patientID,
-  modality,
-  studyDate,
-  isPublic,
-}: createFeedWithFilepathProp): Promise<ApiResult<Feed>> => {
+export const createFeedWithFilepath = async (
+  filepath: string,
+  theName: string,
+  // biome-ignore lint/correctness/noUnusedFunctionParameters: not using tags for now.
+  tags?: string[],
+  isPublic: boolean = false,
+) => {
   const pluginInstanceResult = await createPluginInstance(1, [filepath]);
   if (!pluginInstanceResult.data) {
     return {

src/components/Pacs/utils.ts

@@ -26,30 +26,14 @@ export const createFeedWithPACSSeries = async (series: PACSSeries) => {
     StudyDate: studyDate,
     StudyDescription: studyDescription,
     SeriesDescription: seriesDescription,
-    Modality: modality,
   } = series;
 
   const studyDateStr = studyDate.replace(/[^0-9]/g, "");
 
   const theName = `PACS-${patientID}-${studyDateStr}-${studyDescription}-${seriesDescription}`;
 
-  console.info(
-    "PacsController.createFeedWithPACSSeries: to createFeedWithFilepath: folderPath:",
-    thePath,
-    "theName:",
-    theName,
-  );
-
   const tags = ["pacs"];
-  return await createFeedWithFilepath({
-    filepath: thePath,
-    theName,
-    tags,
-    patientID,
-    modality,
-    studyDate,
-    isPublic: false,
-  });
+  return await createFeedWithFilepath(thePath, theName, tags);
 };
 
 export const errorCodeIs4xx = (e: { code: number }) => {