Skip to content

Commit a39fcd6

Browse files
committed
Merge branch 'staging' of https://github.com/FNNDSC/ChRIS_ui into staging
2 parents 815dc6e + c2db78e commit a39fcd6

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ on:
99
jobs:
1010
build:
1111
runs-on: ubuntu-24.04
12-
if: github.repository_owner == 'FNNDSC' && secrets.GITHUB_TOKEN != ''
1312
steps:
1413
- uses: actions/checkout@v4
1514
with:
@@ -18,7 +17,6 @@ jobs:
1817
- uses: pnpm/action-setup@v4
1918
name: Install pnpm
2019
with:
21-
version: 9
2220
run_install: false
2321
- name: Install Node.js
2422
uses: actions/setup-node@v4
@@ -49,11 +47,14 @@ jobs:
4947
driver-opts: network=host
5048
- name: Login to DockerHub
5149
id: dockerhub_login
50+
continue-on-error: true
5251
uses: docker/login-action@v3
5352
with:
5453
username: ${{ secrets.DOCKERHUB_USERNAME }}
5554
password: ${{ secrets.DOCKERHUB_PASSWORD }}
5655
- name: Login to GitHub Container Registry
56+
id: ghcr_login
57+
continue-on-error: true
5758
uses: docker/login-action@v3
5859
with:
5960
registry: ghcr.io
@@ -67,11 +68,11 @@ jobs:
6768
context: .
6869
file: ./Dockerfile
6970
platforms: linux/amd64,linux/arm64,linux/arm/v6,linux/arm/v7,linux/386
70-
push: true
71+
push: ${{ steps.dockerhub_login.outcome == 'success' && steps.ghcr_login.outcome == 'success' }}
7172

7273
- name: Update DockerHub description
7374
uses: peter-evans/dockerhub-description@v4
74-
if: github.event_name == 'push' && github.ref == 'refs/heads/master'
75+
if: github.event_name == 'push' && github.ref == 'refs/heads/master' && steps.dockerhub_login.outcome == 'success'
7576
with:
7677
username: ${{ secrets.DOCKERHUB_USERNAME }}
7778
password: ${{ secrets.DOCKERHUB_PASSWORD }}

.github/workflows/test.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,14 @@ jobs:
1313
- uses: actions/checkout@v4
1414
with:
1515
fetch-depth: "0" # necessary for `npm run print-version`
16-
- uses: pnpm/action-setup@v2
16+
- uses: pnpm/action-setup@v4
17+
name: Install pnpm
1718
with:
18-
version: 8
19-
- uses: actions/setup-node@v4
19+
run_install: false
20+
- name: Install Node.js
21+
uses: actions/setup-node@v4
2022
with:
21-
node-version: 20.17
23+
node-version: 20
2224
cache: 'pnpm'
2325
- run: pnpm install
2426
- run: pnpm test
@@ -103,4 +105,4 @@ jobs:
103105
token: ${{ secrets.CODECOV_TOKEN }}
104106
files: coverage/lcov.info
105107
flags: e2etests-local
106-
fail_ci_if_error: true
108+
fail_ci_if_error: true

docker-entrypoint.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ source "$env_file"
3636
target=/srv
3737

3838
if find "$target" -mindepth 1 | grep -q .; then
39-
echo "error: $target not empty, refusing to overwrite."
40-
exit 1
39+
>&2 echo "WARNING: $target is not empty, it might contain out-of-date or otherwise stray files. If you just restarted this container, you can ignore this warning."
4140
fi
4241

4342
# create directories in target folder

0 commit comments

Comments
 (0)