Skip to content

Commit f09789c

Browse files
authored
Merge pull request #1395 from chhsiao1981/refactor-sidebar
refactor sidebar and notfound
2 parents 0c89d3a + acc4b99 commit f09789c

File tree

6 files changed

+242
-235
lines changed

6 files changed

+242
-235
lines changed

src/components/NewLibrary/components/Cart.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ import { Drawer, List, Popconfirm, Space } from "../../Antd";
2222
import { DotsIndicator, EmptyStateComponent } from "../../Common";
2323
import { CheckCircleIcon, CloseIcon, FileIcon, FolderIcon } from "../../Icons";
2424
import {
25-
ShowInFolder,
26-
TitleNameClipped,
2725
elipses,
2826
formatBytesWithPadding,
27+
ShowInFolder,
28+
TitleNameClipped,
2929
} from "../utils/longpress";
3030
import "./Cart.css";
3131

src/components/NotFound/index.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Alert } from "@patternfly/react-core";
22
import WrapperConnect from "../Wrapper";
33

4-
const NotFound = () => {
4+
export default () => {
55
return (
66
<WrapperConnect>
77
<Alert
@@ -17,5 +17,3 @@ const NotFound = () => {
1717
</WrapperConnect>
1818
);
1919
};
20-
21-
export default NotFound;
Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
import {
2+
Brand,
3+
Nav,
4+
NavGroup,
5+
NavItem,
6+
NavList,
7+
PageSidebar,
8+
PageSidebarBody,
9+
} from "@patternfly/react-core";
10+
import { Link } from "react-router-dom";
11+
import brandImg from "../../assets/logo_chris_dashboard.png";
12+
import styles from "./Sidebar.module.css";
13+
14+
type Props = {
15+
isNavOpen?: boolean;
16+
sidebarActiveItem?: string;
17+
};
18+
19+
export default (props: Props) => {
20+
const { isNavOpen, sidebarActiveItem } = props;
21+
22+
return (
23+
<PageSidebar isSidebarOpen={isNavOpen}>
24+
<PageSidebarBody>
25+
<div className={styles["page-sidebar"]}>
26+
<div className={styles.nav}>
27+
{" "}
28+
<Nav>
29+
<NavList>
30+
<NavGroup title="Discover ChRIS">
31+
<NavItem
32+
itemId="overview"
33+
isActive={sidebarActiveItem === "overview"}
34+
>
35+
<Link to="/">Overview</Link>
36+
</NavItem>
37+
<NavItem
38+
itemId="shared"
39+
isActive={sidebarActiveItem === "shared"}
40+
>
41+
<Link to="/shared">Shared Data</Link>
42+
</NavItem>
43+
44+
<NavItem
45+
itemId="package"
46+
isActive={sidebarActiveItem === "package"}
47+
>
48+
<Link to="/package">Browse Packages</Link>
49+
</NavItem>
50+
</NavGroup>
51+
</NavList>
52+
</Nav>
53+
</div>
54+
<div className={styles.brand}>
55+
<Brand src={brandImg} alt="ChRIS Logo" />
56+
</div>
57+
</div>
58+
</PageSidebarBody>
59+
</PageSidebar>
60+
);
61+
};

src/components/Wrapper/Sidebar.module.css

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,18 @@
1717

1818
.hide {
1919
display: none;
20+
}
21+
22+
.page-sidebar {
23+
display: flex;
24+
flex-direction: column;
25+
height: 100%;
26+
}
27+
28+
.nav {
29+
flex-grow: 1;
30+
}
31+
32+
.brand {
33+
padding: 16px;
2034
}

0 commit comments

Comments
 (0)