ldpd: fix broken label allocation

rwestphal · rwestphal · commit 2d67d5a2b57a · 2017-09-13T18:58:50.000-03:00
Once ldpd allocated label 48 for a given FEC, all subsequent requests
for a new label would return the same value (48). The problem is that
we were left shifting an uint32_t value up to 64 times, losing important
information.

Signed-off-by: Renato Westphal &lt;renato@opensourcerouting.org&gt;
diff --git a/ldpd/lde.c b/ldpd/lde.c
@@ -1680,7 +1680,8 @@ static uint32_t
 lde_get_next_label(void)
 {
 	struct label_chunk *label_chunk;
-	uint32_t i, pos, size;
+	uint32_t i, size;
+	uint64_t pos;
 	uint32_t label = NO_LABEL;
 
 	while (current_label_chunk) {

Original file line number	Diff line number	Diff line change
`@@ -1680,7 +1680,8 @@ static uint32_t`
`1680`	`1680`	`lde_get_next_label(void)`
`1681`	`1681`	`{`
`1682`	`1682`	`struct label_chunk *label_chunk;`
`1683`		`- uint32_t i, pos, size;`
	`1683`	`+ uint32_t i, size;`
	`1684`	`+ uint64_t pos;`
`1684`	`1685`	`uint32_t label = NO_LABEL;`
`1685`	`1686`
`1686`	`1687`	`while (current_label_chunk) {`