Crash on Newest Update from Fabric 3.0.9 to 4.0.0

[suerion]

Minecraft version information

1.21.1

Mod loader information

Fabric

Mod loader version information

Loading Minecraft 1.21.1 with Fabric Loader 0.16.14

Mod version information

friendsandfoes 4.0.0

Reproduction Steps

Update Friends and Foes from 3.0.9 to 4.0.0

Crash on Server Startup. Look on Latest.log

Crash Report and latest.log

Latest.log:

https://mclo.gs/5TfMd8s

Additional information

Could be some compat issues with accessorify?

[Faboslav]

Its broken compat, can you please report this to accessorify?

[suerion]

Will let it open here, and get an compat for accessorify

[Faboslav]

Thanks, also if the issue is linked, i will be able to see, if i need to do something or not :).

[pajicadvance]

Hi, dev of Accessorify here.

The way Accessorify implements compatibility for totems from your mod before version 4.0.0 is pretty horrible and I'm not happy with it. It's 2 mixins into your mod with one of them being a mixin-into-a-mixin using MixinSquared. This seems to have broken in 4.0.0 and above and I'd like to get rid of the code as it's very low quality and I don't want to maintain it anymore.

Accessorify uses the Accessories API for the accessory slots. This API also has a compatibility layer for the Trinkets API, found here. The reason why I resorted to mixing into your mod in the first place is because this compat layer did not work to make your totems compatible with the Accessories API. I don't know why this is the case as your mod has Trinkets API integration.

The ideal solution here would be to figure out why the compat layer is not working and fix it on your side, or just implement Accessories API in your mod. I know it's additional effort from your side, but it's miles better than me mixing into your mod in questionable ways.