Skip to content

Inconsistent naming for methods Screen#removed and Screen#onDisplayed #4274

@0x000006

Description

@0x000006

They are both called in MinecraftClient#setScreen. Side note: an unwritten rule for event/callback methods beginning with 'on' is for the method to be in present tense.

Suggestions from best to worst in my opinion:

  • Screen#onUnset with Screen#onSet
  • Screen#onRemove with Screen#onDisplay
  • Screen#onRemoved with Screen#onDisplayed
  • Screen#removed with Screen#displayed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions