Fix CLoadingResource::FinalizeLoadRequest crash (#3911)

solwllms · web-flow · commit 4e85d0155c4e · 2026-01-28T18:18:35.000Z
* Prevent premature loading resource cancellation from finalising cyclical dependencies
* GameResource.GetPromise returns null with empty path
diff --git a/engine/Sandbox.Engine/Resources/GameResource.cs b/engine/Sandbox.Engine/Resources/GameResource.cs
@@ -134,8 +134,9 @@ internal bool PostReloadInternal()
 	internal static GameResource GetPromise( System.Type type, string filename )
 	{
 		var path = FixPath( filename );
-		var hash = path.FastHash();
+		if ( string.IsNullOrEmpty( path ) ) return default;
 
+		var hash = path.FastHash();
 		var obj = Game.Resources.Get( type, hash ) as GameResource;
 		if ( obj != null ) return obj;
 

Original file line number	Diff line number	Diff line change
`@@ -134,8 +134,9 @@ internal bool PostReloadInternal()`
`134`	`134`	`internal static GameResource GetPromise( System.Type type, string filename )`
`135`	`135`	`{`
`136`	`136`	`var path = FixPath( filename );`
`137`		`- var hash = path.FastHash();`
	`137`	`+ if ( string.IsNullOrEmpty( path ) ) return default;`
`138`	`138`
	`139`	`+ var hash = path.FastHash();`
`139`	`140`	`var obj = Game.Resources.Get( type, hash ) as GameResource;`
`140`	`141`	`if ( obj != null ) return obj;`
`141`	`142`