VR Fixes 2 (#3458)

Improved error logging, crash fixes, and light menu tweaks

Author: xezno

engine/Definitions/engine/VR/fpxr.def

@@ -28,6 +28,11 @@ native class fpxr::ApplicationConfig as Facepunch.XR.ApplicationConfig
     {
         fpxr::ApplicationConfig::GetInstance().m_debugCallback = (fpxr::PFN_DebugCallback)dbgCallback;
     }
+
+    inline static void SetErrorCallback( IntPtr errCallback )
+    {
+        fpxr::ApplicationConfig::GetInstance().m_errorCallback = (fpxr::PFN_ErrorCallback)errCallback;
+    }
 }
 
 native class fpxr::EventManager as Facepunch.XR.EventManager

engine/Sandbox.Engine/Platform/VR/VRNative.cs

@@ -99,8 +99,15 @@ private static string BufferToString( byte* buffer, uint maxLength )
 	}
 
 	public delegate void DebugUtilsMessengerCallback( string message, DebugCallbackType type );
+	public delegate void DebugUtilsErrorCallback( string message );
 
-	private static Logger Log = new( "VR" );
+	private static Logger Log = new( "OpenXR" );
+
+	private static void XrErrorCallback( string message )
+	{
+		Log.Error( $"{message}" );
+		Application.Exit(); // For now
+	}
 
 	private static void XrDebugCallback( string message, DebugCallbackType type )
 	{
@@ -143,11 +150,17 @@ internal static void CreateInstance()
 		if ( !VRSystem.HasHeadset )
 			return;
 
-		if ( VRSystem.WantsDebug )
+		// Initialize app config callbacks
 		{
-			// Set up a debug callback for logging Facepunch.XR messages
-			var pDebugCallback = Marshal.GetFunctionPointerForDelegate<DebugUtilsMessengerCallback>( XrDebugCallback );
-			ApplicationConfig.SetDebugCallback( pDebugCallback );
+			if ( VRSystem.WantsDebug )
+			{
+				// Set up a debug callback for logging Facepunch.XR messages
+				var pDebugCallback = Marshal.GetFunctionPointerForDelegate<DebugUtilsMessengerCallback>( XrDebugCallback );
+				ApplicationConfig.SetDebugCallback( pDebugCallback );
+			}
+
+			var pErrorCallback = Marshal.GetFunctionPointerForDelegate<DebugUtilsErrorCallback>( XrErrorCallback );
+			ApplicationConfig.SetErrorCallback( pErrorCallback );
 		}
 
 		// Create the OpenXR instance