Fix Texture Generator with 3D Textures (#3632)

* Fix Texture.Read having wrong strides depending on texture format

https://files.facepunch.com/sampavlovic/1b1011b1/qrenderdoc_fXecqvuzKo.png

https://files.facepunch.com/sampavlovic/1b1011b1/qrenderdoc_zHXXguaCkG.png

Makes texture reads and reuploads work correctly

* Fix TextureCompiler not compiling 3D textures properly, make Texture.GetBitmap work with 3D textures

* format

Author: sampavlovic

engine/Sandbox.Engine/Resources/Textures/Texture.Read.cs

@@ -53,18 +53,18 @@ public unsafe Bitmap GetBitmap( int mip )
 		var height = desc.m_nHeight / d;
 		var depth = desc.m_nDepth;
 		var outputFormat = floatingPoint ? ImageFormat.RGBA16161616F : ImageFormat.RGBA8888;
-		var targetMemoryRequired = NativeEngine.ImageLoader.GetMemRequired( width, height, 1, 1, outputFormat );
+		var targetMemoryRequired = NativeEngine.ImageLoader.GetMemRequired( width, height, depth, 1, outputFormat );
 
 		if ( targetMemoryRequired <= 0 )
 		{
 			//
 			// If desc.m_nWidth and height are 0, this is probably the rendersystemempty, which is obviously a disaster
 			//
 
-			throw new System.Exception( $"targetMemoryRequired <= 0 ({width}x{height} {outputFormat})" );
+			throw new System.Exception( $"targetMemoryRequired <= 0 ({width}x{height}x{depth} {outputFormat})" );
 		}
 
-		var bitmap = new Bitmap( width, height, floatingPoint );
+		var bitmap = new Bitmap( width, height * depth, floatingPoint );
 		var data = bitmap.GetBuffer();
 
 		if ( data.Length != targetMemoryRequired )
@@ -74,10 +74,18 @@ public unsafe Bitmap GetBitmap( int mip )
 
 		fixed ( byte* pData = data )
 		{
-			var rect = new NativeRect( 0, 0, width, height );
+			if ( depth > 1 )
+			{
+				GetPixels3D( (0, 0, 0, width, height, depth), mip, data, outputFormat );
+			}
+			else
+			{
+				var rect = new NativeRect( 0, 0, width, height );
+
+				if ( !g_pRenderDevice.ReadTexturePixels( native, ref rect, 0, mip, ref rect, (IntPtr)pData, outputFormat, 0 ) )
+					return null;
+			}
 
-			if ( !g_pRenderDevice.ReadTexturePixels( native, ref rect, 0, mip, ref rect, (IntPtr)pData, outputFormat, 0 ) )
-				return null;
 		}
 
 		return bitmap;
@@ -149,8 +157,10 @@ private static int GetImageFormatSize( ImageFormat format, int width, int height
 			throw new ArgumentException( $"{nameof( srcRect )} out of range" );
 		}
 
-		var dstStride = (long)dstSize.X * pixelSize;
-		if ( dstStride > int.MaxValue || ((long)dstSize.Y * pixelSize) > int.MaxValue )
+		var dstStrideBytes = GetImageFormatSize( dstFormat, dstSize.X, 1 );
+		if ( dstStrideBytes <= 0 )
+			throw new ArgumentException( $"{nameof( dstSize )} invalid" );
+		if ( dstStrideBytes > int.MaxValue )
 			throw new ArgumentException( $"{nameof( dstSize )} too large" );
 
 		var sliceSize = GetImageFormatSize( dstFormat, dstSize.X, dstSize.Y );
@@ -173,7 +183,7 @@ private static int GetImageFormatSize( ImageFormat format, int width, int height
 
 		fixed ( T* dataPtr = dstData )
 		{
-			if ( !g_pRenderDevice.ReadTexturePixels( native, ref nativeSrcRect, slice, mip, ref nativeDstRect, (IntPtr)dataPtr, dstFormat, (int)dstStride ) )
+			if ( !g_pRenderDevice.ReadTexturePixels( native, ref nativeSrcRect, slice, mip, ref nativeDstRect, (IntPtr)dataPtr, dstFormat, dstStrideBytes ) )
 				throw new Exception( "Unable to read texture pixels" );
 		}
 	}

engine/Sandbox.Tools/Assets/ResourceCompile/TextureCompiler.cs

@@ -59,6 +59,31 @@ override protected async Task<bool> Compile()
 		writer.Header.Depth = (ushort)depth;
 		writer.Header.MipCount = (byte)mipCount;
 
+		var desc = texture.Desc;
+		var flags = VTexWriter.VTEX_Flags_t.NONE;
+
+		if ( desc.m_nFlags.HasFlag( NativeEngine.RuntimeTextureSpecificationFlags.TSPEC_CUBE_TEXTURE ) )
+		{
+			flags |= VTexWriter.VTEX_Flags_t.VTEX_FLAG_CUBE_TEXTURE;
+		}
+
+		if ( desc.m_nFlags.HasFlag( NativeEngine.RuntimeTextureSpecificationFlags.TSPEC_VOLUME_TEXTURE ) )
+		{
+			flags |= VTexWriter.VTEX_Flags_t.VTEX_FLAG_VOLUME_TEXTURE;
+		}
+
+		if ( desc.m_nFlags.HasFlag( NativeEngine.RuntimeTextureSpecificationFlags.TSPEC_TEXTURE_ARRAY ) )
+		{
+			flags |= VTexWriter.VTEX_Flags_t.VTEX_FLAG_TEXTURE_ARRAY;
+		}
+
+		if ( desc.m_nFlags.HasFlag( NativeEngine.RuntimeTextureSpecificationFlags.TSPEC_NO_LOD ) )
+		{
+			flags |= VTexWriter.VTEX_Flags_t.VTEX_FLAG_NO_LOD;
+		}
+
+		writer.Header.Flags = flags;
+
 		writer.CalculateFormat();
 
 		Context.Data.Write( writer.GetData() );