Skip to content

Commit f502831

Browse files
committed
fix(ui): resolve hover flicker on icon edges and quote sound-in SCSS values
- Add pointer-events: none to tooltip panels (MainMenu, MenuOverlay) - Expand icon hit areas with padding (Avatar, PartyDeck, FriendEntry) - Fix ::after overlay stealing pointer events (GameCard) - Quote all sound-in values to prevent SCSS parse errors (23 files) Fixes #10329
1 parent bcb38b1 commit f502831

23 files changed

+63
-77
lines changed

game/addons/menu/Code/AvatarEditor/AvatarUI.razor.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,15 @@ AvatarUI > .controls
9090
{
9191
opacity: 1;
9292
background-color: #08f;
93-
sound-in: ui.button.over;
93+
sound-in: "ui.button.over";
9494
}
9595

9696
&:active
9797
{
9898
background-color: white;
9999
color: #222;
100100
opacity: 1;
101-
sound-in: ui.button.press;
101+
sound-in: "ui.button.press";
102102
}
103103
}
104104

@@ -176,13 +176,13 @@ ButtonGroup, .buttongroup
176176
> *:hover
177177
{
178178
opacity: 1;
179-
sound-in: ui.button.over;
179+
sound-in: "ui.button.over";
180180
}
181181

182182
> *:active
183183
{
184184
background-color: #2af;
185-
sound-in: ui.button.press;
185+
sound-in: "ui.button.press";
186186
}
187187

188188
> *.active

game/addons/menu/Code/AvatarEditor/UI/ClothingIcon.razor.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ ClothingIcon
1818
&:hover
1919
{
2020
background-color: #0088ff55;
21-
sound-in: ui.button.over;
21+
sound-in: "ui.button.over";
2222
}
2323

2424
&.active

game/addons/menu/Code/AvatarEditor/UI/ClothingItemSelector.razor.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ ClothingItemSelector > .category
9595
&:hover
9696
{
9797
opacity: 1;
98-
sound-in: ui.button.over;
98+
sound-in: "ui.button.over";
9999
}
100100

101101
&:active

game/addons/menu/Code/MainMenu.razor.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
}
1111

1212
.tooltip {
13+
pointer-events: none;
1314
background-color: #656e7e;
1415
font-family: Poppins;
1516
border: none;

game/addons/menu/Code/MenuUI/Components/Footer.razor.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ Footer {
4040
border-radius: $rounding-large;
4141

4242
&:active {
43-
sound-in: ui.button.press;
43+
sound-in: "ui.button.press";
4444
}
4545

4646
&:hover {
47-
sound-in: ui.button.over;
47+
sound-in: "ui.button.over";
4848
cursor: pointer;
4949
background-color: $default-800;
5050
}
@@ -77,11 +77,11 @@ Footer {
7777
border: 1px solid transparent; // Avoid layout shifts
7878

7979
&:active {
80-
sound-in: ui.button.press;
80+
sound-in: "ui.button.press";
8181
}
8282

8383
&:hover {
84-
sound-in: ui.button.over;
84+
sound-in: "ui.button.over";
8585
border: 1px solid $default-border;
8686
cursor: pointer;
8787
border-radius: $rounding-default;

game/addons/menu/Code/MenuUI/Components/GameClosedToast.razor.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ GameClosedToast
1010
box-shadow: 5px 5px 20px rgba( black, 0.8 );
1111
opacity: 1;
1212
transition: all 0.2s ease-out;
13-
sound-in: ui.popup.message.open;
13+
sound-in: "ui.popup.message.open";
1414
overflow: hidden;
1515
flex-direction: row;
1616
background-color: #1b202c;

game/addons/menu/Code/MenuUI/Components/GameClosing.razor.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
box-shadow: 5px 5px 20px rgba( black, 0.5 );
1616
opacity: 1;
1717
transition: all 0.4s bounce-out;
18-
sound-in: ui.popup.message.open;
18+
sound-in: "ui.popup.message.open";
1919
overflow: hidden;
2020
padding-left: 70px;
2121
position: relative;

game/addons/menu/Code/MenuUI/Components/GameStarting.razor.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
box-shadow: 5px 5px 20px rgba( black, 0.8 );
1414
opacity: 1;
1515
transition: all 0.2s ease-out;
16-
sound-in: ui.popup.message.open;
16+
sound-in: "ui.popup.message.open";
1717
overflow: hidden;
1818
padding: 8px;
1919
bottom: 0px;

game/addons/menu/Code/MenuUI/Components/New/Avatar.razor.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
Avatar
44
{
55
pointer-events: all;
6+
padding: 4px;
7+
margin: -4px;
68

79
.avatar
810
{

game/addons/menu/Code/MenuUI/Components/New/Carousel.razor.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ Carousel {
3636
}
3737

3838
&:active {
39-
sound-in: ui.button.press;
39+
sound-in: "ui.button.press";
4040
}
4141

4242
&:hover {
43-
sound-in: ui.button.over;
43+
sound-in: "ui.button.over";
4444
background-color: $default-800;
4545

4646
.icon {

0 commit comments

Comments
 (0)