Update version to 0.0.2b4 and enhance unit tests for trigger_graph functionality

- Incremented the version in _version.py to 0.0.2b4.
- Added multiple unit tests for the trigger_graph function to cover various scenarios, including handling dependent strings, validation errors, and edge cases with empty or invalid inputs.
- Improved assertions in existing tests to ensure comprehensive coverage and robustness of the trigger_graph functionality.

Author: NiveditJain

python-sdk/exospherehost/_version.py

@@ -1 +1 @@
-version = "0.0.2b3"
+version = "0.0.2b4"

state-manager/tests/unit/controller/test_trigger_graph.py

@@ -126,3 +126,287 @@ async def test_trigger_graph_value_error_not_graph_template_not_found(mock_reque
 
         with pytest.raises(ValueError, match="Some other validation error"):
             await trigger_graph(namespace_name, graph_name, mock_request, x_exosphere_request_id)
+
+
+@pytest.mark.asyncio
+async def test_trigger_graph_with_dependent_strings():
+    """Test trigger_graph with dependent strings in inputs"""
+    namespace_name = "test_namespace"
+    graph_name = "test_graph"
+    x_exosphere_request_id = "test_request_id"
+
+    req = TriggerGraphRequestModel(
+        store={"store_key": "store_value"},
+        inputs={"input1": "{{store.store_key}}_suffix"}
+    )
+
+    with patch('app.controller.trigger_graph.GraphTemplate') as mock_graph_template_cls, \
+         patch('app.controller.trigger_graph.Store') as mock_store_cls, \
+         patch('app.controller.trigger_graph.State') as mock_state_cls, \
+         patch('app.controller.trigger_graph.Run') as mock_run_cls, \
+         patch('app.controller.trigger_graph.DependentString') as mock_dependent_string_cls:
+
+        mock_graph_template = MagicMock()
+        mock_graph_template.is_valid.return_value = True
+        mock_graph_template.store_config.required_keys = []
+        mock_root_node = MagicMock()
+        mock_root_node.node_name = "root_node"
+        mock_root_node.identifier = "root_id"
+        mock_root_node.inputs = {"input1": "{{store.store_key}}_suffix"}
+        mock_graph_template.get_root_node.return_value = mock_root_node
+        mock_graph_template_cls.get = AsyncMock(return_value=mock_graph_template)
+
+        # Mock dependent string behavior
+        mock_dependent_string = MagicMock()
+        mock_dependent = MagicMock()
+        mock_dependent.identifier = "store"
+        mock_dependent.field = "store_key"
+        mock_dependent_string.dependents = {0: mock_dependent}
+        mock_dependent_string.generate_string.return_value = "store_value_suffix"
+        mock_dependent_string_cls.create_dependent_string.return_value = mock_dependent_string
+
+        mock_store_cls.insert_many = AsyncMock(return_value=None)
+        mock_state_instance = MagicMock()
+        mock_state_instance.insert = AsyncMock(return_value=None)
+        mock_state_cls.return_value = mock_state_instance
+        
+        mock_run_instance = MagicMock()
+        mock_run_instance.insert = AsyncMock(return_value=None)
+        mock_run_cls.return_value = mock_run_instance
+
+        result = await trigger_graph(namespace_name, graph_name, req, x_exosphere_request_id)
+
+        assert result.status == StateStatusEnum.CREATED
+        mock_dependent_string_cls.create_dependent_string.assert_called()
+
+
+@pytest.mark.asyncio
+async def test_trigger_graph_with_invalid_dependent_identifier():
+    """Test trigger_graph with invalid dependent identifier (not 'store')"""
+    namespace_name = "test_namespace"
+    graph_name = "test_graph"
+    x_exosphere_request_id = "test_request_id"
+
+    req = TriggerGraphRequestModel(
+        store={"store_key": "store_value"},
+        inputs={"input1": "{{invalid.identifier}}"}
+    )
+
+    with patch('app.controller.trigger_graph.GraphTemplate') as mock_graph_template_cls, \
+         patch('app.controller.trigger_graph.DependentString') as mock_dependent_string_cls:
+
+        mock_graph_template = MagicMock()
+        mock_graph_template.is_valid.return_value = True
+        mock_graph_template.store_config.required_keys = []
+        mock_root_node = MagicMock()
+        mock_root_node.node_name = "root_node"
+        mock_root_node.identifier = "root_id"
+        mock_root_node.inputs = {"input1": "{{invalid.identifier}}"}
+        mock_graph_template.get_root_node.return_value = mock_root_node
+        mock_graph_template_cls.get = AsyncMock(return_value=mock_graph_template)
+
+        # Mock dependent string behavior with invalid identifier
+        mock_dependent_string = MagicMock()
+        mock_dependent = MagicMock()
+        mock_dependent.identifier = "invalid"
+        mock_dependent.field = "identifier"
+        mock_dependent_string.dependents = {0: mock_dependent}
+        mock_dependent_string_cls.create_dependent_string.return_value = mock_dependent_string
+
+        with pytest.raises(HTTPException) as exc_info:
+            await trigger_graph(namespace_name, graph_name, req, x_exosphere_request_id)
+
+        assert exc_info.value.status_code == 400
+        assert "Root node can have only store identifier as dependent" in exc_info.value.detail
+
+
+@pytest.mark.asyncio
+async def test_trigger_graph_with_missing_store_field():
+    """Test trigger_graph with missing store field in dependent string"""
+    namespace_name = "test_namespace"
+    graph_name = "test_graph"
+    x_exosphere_request_id = "test_request_id"
+
+    req = TriggerGraphRequestModel(
+        store={"other_key": "other_value"},
+        inputs={"input1": "{{store.missing_key}}"}
+    )
+
+    with patch('app.controller.trigger_graph.GraphTemplate') as mock_graph_template_cls, \
+         patch('app.controller.trigger_graph.DependentString') as mock_dependent_string_cls:
+
+        mock_graph_template = MagicMock()
+        mock_graph_template.is_valid.return_value = True
+        mock_graph_template.store_config.required_keys = []
+        mock_graph_template.store_config.default_values = {}
+        mock_root_node = MagicMock()
+        mock_root_node.node_name = "root_node"
+        mock_root_node.identifier = "root_id"
+        mock_root_node.inputs = {"input1": "{{store.missing_key}}"}
+        mock_graph_template.get_root_node.return_value = mock_root_node
+        mock_graph_template_cls.get = AsyncMock(return_value=mock_graph_template)
+
+        # Mock dependent string behavior with missing store field
+        mock_dependent_string = MagicMock()
+        mock_dependent = MagicMock()
+        mock_dependent.identifier = "store"
+        mock_dependent.field = "missing_key"
+        mock_dependent_string.dependents = {0: mock_dependent}
+        mock_dependent_string_cls.create_dependent_string.return_value = mock_dependent_string
+
+        with pytest.raises(HTTPException) as exc_info:
+            await trigger_graph(namespace_name, graph_name, req, x_exosphere_request_id)
+
+        assert exc_info.value.status_code == 400
+        assert "Dependent missing_key not found in store" in exc_info.value.detail
+
+
+@pytest.mark.asyncio
+async def test_trigger_graph_with_store_default_values():
+    """Test trigger_graph with store default values"""
+    namespace_name = "test_namespace"
+    graph_name = "test_graph"
+    x_exosphere_request_id = "test_request_id"
+
+    req = TriggerGraphRequestModel(
+        store={"other_key": "other_value"},
+        inputs={"input1": "{{store.missing_key}}"}
+    )
+
+    with patch('app.controller.trigger_graph.GraphTemplate') as mock_graph_template_cls, \
+         patch('app.controller.trigger_graph.Store') as mock_store_cls, \
+         patch('app.controller.trigger_graph.State') as mock_state_cls, \
+         patch('app.controller.trigger_graph.Run') as mock_run_cls, \
+         patch('app.controller.trigger_graph.DependentString') as mock_dependent_string_cls:
+
+        mock_graph_template = MagicMock()
+        mock_graph_template.is_valid.return_value = True
+        mock_graph_template.store_config.required_keys = []
+        mock_graph_template.store_config.default_values = {"missing_key": "default_value"}
+        mock_root_node = MagicMock()
+        mock_root_node.node_name = "root_node"
+        mock_root_node.identifier = "root_id"
+        mock_root_node.inputs = {"input1": "{{store.missing_key}}"}
+        mock_graph_template.get_root_node.return_value = mock_root_node
+        mock_graph_template_cls.get = AsyncMock(return_value=mock_graph_template)
+
+        # Mock dependent string behavior with default value
+        mock_dependent_string = MagicMock()
+        mock_dependent = MagicMock()
+        mock_dependent.identifier = "store"
+        mock_dependent.field = "missing_key"
+        mock_dependent_string.dependents = {0: mock_dependent}
+        mock_dependent_string.generate_string.return_value = "default_value"
+        mock_dependent_string_cls.create_dependent_string.return_value = mock_dependent_string
+
+        mock_store_cls.insert_many = AsyncMock(return_value=None)
+        mock_state_instance = MagicMock()
+        mock_state_instance.insert = AsyncMock(return_value=None)
+        mock_state_cls.return_value = mock_state_instance
+        
+        mock_run_instance = MagicMock()
+        mock_run_instance.insert = AsyncMock(return_value=None)
+        mock_run_cls.return_value = mock_run_instance
+
+        result = await trigger_graph(namespace_name, graph_name, req, x_exosphere_request_id)
+
+        assert result.status == StateStatusEnum.CREATED
+        mock_dependent_string.set_value.assert_called_with("store", "missing_key", "default_value")
+
+
+@pytest.mark.asyncio
+async def test_trigger_graph_with_input_processing_error():
+    """Test trigger_graph with error during input processing"""
+    namespace_name = "test_namespace"
+    graph_name = "test_graph"
+    x_exosphere_request_id = "test_request_id"
+
+    req = TriggerGraphRequestModel(
+        store={"key": "value"},
+        inputs={"input1": "{{store.key}}"}
+    )
+
+    with patch('app.controller.trigger_graph.GraphTemplate') as mock_graph_template_cls, \
+         patch('app.controller.trigger_graph.DependentString') as mock_dependent_string_cls:
+
+        mock_graph_template = MagicMock()
+        mock_graph_template.is_valid.return_value = True
+        mock_graph_template.store_config.required_keys = []
+        mock_root_node = MagicMock()
+        mock_root_node.node_name = "root_node"
+        mock_root_node.identifier = "root_id"
+        mock_root_node.inputs = {"input1": "{{store.key}}"}
+        mock_graph_template.get_root_node.return_value = mock_root_node
+        mock_graph_template_cls.get = AsyncMock(return_value=mock_graph_template)
+
+        # Mock dependent string behavior that raises an error
+        mock_dependent_string = MagicMock()
+        mock_dependent = MagicMock()
+        mock_dependent.identifier = "store"
+        mock_dependent.field = "key"
+        mock_dependent_string.dependents = {0: mock_dependent}
+        mock_dependent_string_cls.create_dependent_string.return_value = mock_dependent_string
+        mock_dependent_string.generate_string.side_effect = Exception("Input processing error")
+
+        with pytest.raises(HTTPException) as exc_info:
+            await trigger_graph(namespace_name, graph_name, req, x_exosphere_request_id)
+
+        assert exc_info.value.status_code == 400
+        assert "Invalid input: Input processing error" in exc_info.value.detail
+
+
+@pytest.mark.asyncio
+async def test_trigger_graph_with_empty_store():
+    """Test trigger_graph with empty store (no stores to insert)"""
+    namespace_name = "test_namespace"
+    graph_name = "test_graph"
+    x_exosphere_request_id = "test_request_id"
+
+    req = TriggerGraphRequestModel(store={}, inputs={})
+
+    with patch('app.controller.trigger_graph.GraphTemplate') as mock_graph_template_cls, \
+         patch('app.controller.trigger_graph.Store') as mock_store_cls, \
+         patch('app.controller.trigger_graph.State') as mock_state_cls, \
+         patch('app.controller.trigger_graph.Run') as mock_run_cls:
+
+        mock_graph_template = MagicMock()
+        mock_graph_template.is_valid.return_value = True
+        mock_graph_template.store_config.required_keys = []
+        mock_root_node = MagicMock()
+        mock_root_node.node_name = "root_node"
+        mock_root_node.identifier = "root_id"
+        mock_root_node.inputs = {}
+        mock_graph_template.get_root_node.return_value = mock_root_node
+        mock_graph_template_cls.get = AsyncMock(return_value=mock_graph_template)
+
+        mock_store_cls.insert_many = AsyncMock(return_value=None)
+        mock_state_instance = MagicMock()
+        mock_state_instance.insert = AsyncMock(return_value=None)
+        mock_state_cls.return_value = mock_state_instance
+        
+        mock_run_instance = MagicMock()
+        mock_run_instance.insert = AsyncMock(return_value=None)
+        mock_run_cls.return_value = mock_run_instance
+
+        result = await trigger_graph(namespace_name, graph_name, req, x_exosphere_request_id)
+
+        assert result.status == StateStatusEnum.CREATED
+        # Store.insert_many should not be called when store is empty
+        mock_store_cls.insert_many.assert_not_called()
+
+
+@pytest.mark.asyncio
+async def test_trigger_graph_general_exception():
+    """Test trigger_graph with general exception handling"""
+    namespace_name = "test_namespace"
+    graph_name = "test_graph"
+    x_exosphere_request_id = "test_request_id"
+
+    req = TriggerGraphRequestModel(store={"key": "value"}, inputs={})
+
+    with patch('app.controller.trigger_graph.GraphTemplate') as mock_graph_template_cls:
+        # Simulate a general exception during graph template retrieval
+        mock_graph_template_cls.get.side_effect = Exception("Database connection error")
+        
+        with pytest.raises(Exception, match="Database connection error"):
+            await trigger_graph(namespace_name, graph_name, req, x_exosphere_request_id)

state-manager/tests/unit/models/test_retry_policy_model_extended.py

@@ -52,7 +52,7 @@ def test_compute_delay_all_strategies(self):
         for strategy in strategies:
             policy.strategy = strategy
             delay = policy.compute_delay(1)
-            assert delay > 0
+            assert delay >= 0  # Some strategies might return 0 for first retry
             assert delay <= 10000  # max_delay
 
     def test_compute_delay_with_max_delay_cap(self):