Skip to content

Commit 72ff4b1

Browse files
committed
Refactor trigger creation logic in verify_graph.py
- Updated the import path for `get_settings` to align with the new structure. - Modified the `create_crons` function to ensure at least one event is inserted for each cron trigger, improving the handling of trigger times and preventing unnecessary database inserts.
1 parent 37b4843 commit 72ff4b1

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

state-manager/app/tasks/verify_graph.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from app.singletons.logs_manager import LogsManager
1212
from app.models.trigger_models import Trigger, CronTrigger, TriggerStatusEnum, TriggerTypeEnum
1313
from app.models.db.trigger import Triggers as DatabaseTriggers
14-
from config.settings import get_settings
14+
from app.config.settings import get_settings
1515

1616
logger = LogsManager().get_logger()
1717

@@ -134,9 +134,11 @@ async def create_crons(graph_template: GraphTemplate, old_triggers: list[Trigger
134134
new_db_triggers = []
135135
for cron in crons_to_create:
136136
iter = croniter.croniter(cron.expression, current_time)
137-
next_trigger_time = iter.get_next(datetime)
138137

139-
while (next_trigger_time < limit_time):
138+
while(True):
139+
next_trigger_time = iter.get_next(datetime)
140+
141+
# at least one event should be inserted for the cron
140142
new_db_triggers.append(
141143
DatabaseTriggers(
142144
type=TriggerTypeEnum.CRON,
@@ -146,8 +148,11 @@ async def create_crons(graph_template: GraphTemplate, old_triggers: list[Trigger
146148
trigger_time=next_trigger_time
147149
)
148150
)
149-
next_trigger_time = iter.get_next(datetime)
150-
await DatabaseTriggers.insert_many(new_db_triggers)
151+
if next_trigger_time > limit_time:
152+
break
153+
154+
if len(new_db_triggers) > 0:
155+
await DatabaseTriggers.insert_many(new_db_triggers)
151156

152157
async def verify_graph(graph_template: GraphTemplate, old_triggers: list[Trigger]):
153158
try:

0 commit comments

Comments
 (0)