Address reviewer feedback and CI errors: Python version, error response test, Redis CI service and artefacts

Author: namidanam

api-server/pyproject.toml

@@ -22,6 +22,7 @@ dev = [
     "ruff>=0.12.2",
     "pytest>=8.0.0",
     "httpx>=0.27.0",
+     "pytest-cov>=5.0.0"
 ]
 
 

api-server/tests/test_unhandled_exceptions_middleware.py

@@ -4,26 +4,55 @@
 from fastapi.testclient import TestClient
 from app.middlewares.unhandled_exceptions_middleware import UnhandledExceptionsMiddleware
 
-# Endpoint that will always raise an error to test error handling
+# Handlers for various exception types
+
+# 1. RuntimeError
 async def fail(request: Request):
     raise RuntimeError("boom")
 
-# Endpoint for a healthy request
+# 2. ValueError
+async def fail_value_error(request: Request):
+    raise ValueError("Invalid value test")
+
+# 3. KeyError
+async def fail_key_error(request: Request):
+    raise KeyError("Missing key test")
+
+# 4. Healthy endpoint
 async def ok(request: Request):
     return JSONResponse({"ok": True})
 
 @pytest.fixture
 def client():
     app = FastAPI()
-    app.add_middleware(UnhandledExceptionsMiddleware)      # Only exception middleware
+    app.add_middleware(UnhandledExceptionsMiddleware)
     app.add_api_route("/fail", fail, methods=["GET"])
+    app.add_api_route("/fail_value_error", fail_value_error, methods=["GET"])
+    app.add_api_route("/fail_key_error", fail_key_error, methods=["GET"])
     app.add_api_route("/ok", ok, methods=["GET"])
     return TestClient(app)
 
-def test_exception_returns_expected_json(client):
+def test_runtime_error_returns_expected_json(client):
     resp = client.get("/fail")
     assert resp.status_code == 500
     response_json = resp.json()
+    assert response_json.get("success") is False
+    assert "detail" in response_json
+    assert "server error" in response_json["detail"].lower()
+
+def test_value_error_returns_expected_json(client):
+    resp = client.get("/fail_value_error")
+    assert resp.status_code == 500
+    response_json = resp.json()
+    assert response_json.get("success") is False
+    assert "detail" in response_json
+    assert "server error" in response_json["detail"].lower()
+
+def test_key_error_returns_expected_json(client):
+    resp = client.get("/fail_key_error")
+    assert resp.status_code == 500
+    response_json = resp.json()
+    assert response_json.get("success") is False
     assert "detail" in response_json
     assert "server error" in response_json["detail"].lower()