refactor: update trigger status filtering and add expiration logic

- Changed the partial filter expression in DatabaseTriggers to exclude PENDING and TRIGGERING statuses.
- Introduced an expires_at field in create_crons to set expiration time for triggers based on retention settings, ensuring proper cleanup of triggers after their designated retention period.

This enhances the management of trigger states and ensures that only relevant triggers are retained in the database.

Author: NiveditJain

state-manager/app/models/db/trigger.py

@@ -42,9 +42,9 @@ class Settings:
                 expireAfterSeconds=0,  # Delete immediately when expires_at is reached
                 partialFilterExpression={
                     "trigger_status": {
-                        "$in": [
-                            TriggerStatusEnum.TRIGGERED,
-                            TriggerStatusEnum.FAILED
+                        "$nin": [
+                            TriggerStatusEnum.PENDING,
+                            TriggerStatusEnum.TRIGGERING
                         ]
                     }
                 }

state-manager/app/tasks/verify_graph.py

@@ -10,9 +10,13 @@
 from app.singletons.logs_manager import LogsManager
 from app.models.trigger_models import TriggerStatusEnum, TriggerTypeEnum
 from app.models.db.trigger import DatabaseTriggers
+from app.config.settings import get_settings
+from datetime import timedelta
 
 logger = LogsManager().get_logger()
 
+settings = get_settings()
+
 async def verify_node_exists(graph_template: GraphTemplate, registered_nodes: list[RegisteredNode]) -> list[str]:
     errors = []
     template_nodes_set = set([(node.node_name, node.namespace) for node in graph_template.nodes])
@@ -110,6 +114,7 @@ async def create_crons(graph_template: GraphTemplate):
         iter = croniter.croniter(expression, current_time)
 
         next_trigger_time = iter.get_next(datetime)
+        expires_at = next_trigger_time + timedelta(hours=settings.trigger_retention_hours)
 
         new_db_triggers.append(
             DatabaseTriggers(
@@ -118,7 +123,8 @@ async def create_crons(graph_template: GraphTemplate):
                 graph_name=graph_template.name,
                 namespace=graph_template.namespace,
                 trigger_status=TriggerStatusEnum.PENDING,
-                trigger_time=next_trigger_time
+                trigger_time=next_trigger_time,
+                expires_at=expires_at
             )
         )