Skip to content

Commit e7fc2f7

Browse files
committed
fix: ensure timezone-aware datetime in trigger tests
- Updated test cases in test_trigger_cron.py to use timezone-aware datetime by replacing naive datetime.now() with datetime.now(timezone.utc). - Added timezone attribute to the trigger mock to ensure consistency in testing future triggers.
1 parent cacf060 commit e7fc2f7

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

state-manager/tests/unit/tasks/test_trigger_cron.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,10 @@ async def test_call_trigger_graph():
257257
@pytest.mark.asyncio
258258
async def test_create_next_triggers_creates_future_trigger():
259259
"""Test create_next_triggers creates next trigger in the future"""
260-
cron_time = datetime.now(timezone.utc)
260+
cron_time = datetime.now(timezone.utc).replace(tzinfo=None)
261261
trigger = MagicMock(spec=DatabaseTriggers)
262262
trigger.expression = "0 9 * * *"
263+
trigger.timezone = "UTC"
263264
trigger.trigger_time = cron_time - timedelta(days=1)
264265
trigger.graph_name = "test_graph"
265266
trigger.namespace = "test_ns"
@@ -357,9 +358,10 @@ async def test_create_next_triggers_creates_multiple_triggers():
357358
@pytest.mark.asyncio
358359
async def test_create_next_triggers_raises_on_other_exceptions():
359360
"""Test create_next_triggers raises on non-DuplicateKeyError exceptions"""
360-
cron_time = datetime.now(timezone.utc)
361+
cron_time = datetime.now(timezone.utc).replace(tzinfo=None)
361362
trigger = MagicMock(spec=DatabaseTriggers)
362363
trigger.expression = "0 9 * * *"
364+
trigger.timezone = "UTC"
363365
trigger.trigger_time = cron_time - timedelta(days=1)
364366
trigger.graph_name = "test_graph"
365367
trigger.namespace = "test_ns"

0 commit comments

Comments
 (0)