Skip to content

Commit edbbfcf

Browse files
committed
improving triggers
1 parent 0d0700e commit edbbfcf

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

state-manager/app/tasks/trigger_cron.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ async def mark_as_failed(trigger: DatabaseTriggers):
4242

4343
async def create_next_triggers(trigger: DatabaseTriggers, cron_time: datetime):
4444
assert trigger.expression is not None
45-
iter = croniter.croniter(trigger.expression)
45+
iter = croniter.croniter(trigger.expression, trigger.trigger_time)
4646

4747
while True:
4848
next_trigger_time = iter.get_next(datetime)
@@ -58,10 +58,8 @@ async def create_next_triggers(trigger: DatabaseTriggers, cron_time: datetime):
5858
).insert()
5959
except DuplicateKeyError:
6060
logger.error(f"Duplicate trigger found for expression {trigger.expression}")
61-
continue
6261
except Exception as e:
6362
logger.error(f"Error creating next trigger: {e}")
64-
continue
6563

6664
if next_trigger_time > cron_time:
6765
break

0 commit comments

Comments
 (0)