Enhance validation in ReEnqueueAfterRequestModel tests

- Updated tests for ReEnqueueAfterRequestModel to raise exceptions for zero and negative delay values, ensuring stricter validation.
- Adjusted test cases in related signal tests to reflect the new validation rules, improving overall test reliability and coverage.

Author: NiveditJain

state-manager/tests/unit/controller/test_re_queue_after_signal.py

@@ -110,7 +110,7 @@ async def test_re_queue_after_signal_with_zero_delay(
         """Test re-enqueuing with zero delay"""
         # Arrange
         mock_time.time.return_value = 1000.0
-        re_enqueue_request = ReEnqueueAfterRequestModel(enqueue_after=0)
+        re_enqueue_request = ReEnqueueAfterRequestModel(enqueue_after=1)
         mock_state_any_status.save = AsyncMock()
         mock_state_class.find_one = AsyncMock(return_value=mock_state_any_status)
 
@@ -124,8 +124,8 @@ async def test_re_queue_after_signal_with_zero_delay(
 
         # Assert
         assert result.status == StateStatusEnum.CREATED
-        assert result.enqueue_after == 1000000  # 1000 * 1000 + 0
-        assert mock_state_any_status.enqueue_after == 1000000
+        assert result.enqueue_after == 1000001  # 1000 * 1000 + 0
+        assert mock_state_any_status.enqueue_after == 1000001
         assert mock_state_any_status.save.call_count == 1
 
     @patch('app.controller.re_queue_after_signal.State')
@@ -173,24 +173,13 @@ async def test_re_queue_after_signal_with_negative_delay(
     ):
         """Test re-enqueuing with negative delay (should still work)"""
         # Arrange
-        mock_time.time.return_value = 1000.0
-        re_enqueue_request = ReEnqueueAfterRequestModel(enqueue_after=-5000)  # Negative delay
-        mock_state_any_status.save = AsyncMock()
-        mock_state_class.find_one = AsyncMock(return_value=mock_state_any_status)
-
-        # Act
-        result = await re_queue_after_signal(
-            mock_namespace,
-            mock_state_id,
-            re_enqueue_request,
-            mock_request_id
-        )
+        
+        with pytest.raises(Exception):
+            ReEnqueueAfterRequestModel(enqueue_after=-5000)  # Negative delay
 
-        # Assert
-        assert result.status == StateStatusEnum.CREATED
-        assert result.enqueue_after == 995000  # 1000 * 1000 + (-5000)
-        assert mock_state_any_status.enqueue_after == 995000
-        assert mock_state_any_status.save.call_count == 1
+        with pytest.raises(Exception):
+            ReEnqueueAfterRequestModel(enqueue_after=0)
+  
 
     @patch('app.controller.re_queue_after_signal.State')
     async def test_re_queue_after_signal_database_error(

state-manager/tests/unit/models/test_signal_models.py

@@ -77,21 +77,15 @@ def test_re_enqueue_after_request_model_valid_delay(self):
     def test_re_enqueue_after_request_model_zero_delay(self):
         """Test ReEnqueueAfterRequestModel with zero delay"""
         # Arrange & Act
-        delay = 0
-        model = ReEnqueueAfterRequestModel(enqueue_after=delay)
-        
-        # Assert
-        assert model.enqueue_after == delay
+        with pytest.raises(Exception):
+            ReEnqueueAfterRequestModel(enqueue_after=0)
 
     def test_re_enqueue_after_request_model_negative_delay(self):
         """Test ReEnqueueAfterRequestModel with negative delay"""
         # Arrange & Act
-        delay = -5000
-        model = ReEnqueueAfterRequestModel(enqueue_after=delay)
-        
-        # Assert
-        assert model.enqueue_after == delay
-
+        with pytest.raises(Exception):
+            ReEnqueueAfterRequestModel(enqueue_after=-5000)
+    
     def test_re_enqueue_after_request_model_large_delay(self):
         """Test ReEnqueueAfterRequestModel with large delay"""
         # Arrange & Act

state-manager/tests/unit/test_routes.py

@@ -153,13 +153,13 @@ def test_re_enqueue_after_request_model_validation(self):
 
         # Test with zero delay
         zero_data = {"enqueue_after": 0}
-        model = ReEnqueueAfterRequestModel(**zero_data)
-        assert model.enqueue_after == 0
+        with pytest.raises(Exception):
+            ReEnqueueAfterRequestModel(**zero_data)
 
         # Test with negative delay
         negative_data = {"enqueue_after": -5000}
-        model = ReEnqueueAfterRequestModel(**negative_data)
-        assert model.enqueue_after == -5000
+        with pytest.raises(Exception):
+            ReEnqueueAfterRequestModel(**negative_data)
 
         # Test with large delay
         large_data = {"enqueue_after": 86400000}
@@ -821,11 +821,9 @@ async def test_re_enqueue_after_state_route_with_different_delays(self, mock_re_
 
         # Test cases with different delays
         test_cases = [
-            0,  # No delay
             1000,  # 1 second
             60000,  # 1 minute
-            3600000,  # 1 hour
-            -5000  # Negative delay
+            3600000  # 1 hour
         ]
 
         for delay in test_cases: