possible fix for Faithful-Resource-Pack/Web-App#138

3vorp · 3vorp · commit f36352b734c7 · 2025-02-25T17:36:49.000-08:00
diff --git a/src/v2/service/texture.service.ts b/src/v2/service/texture.service.ts
@@ -129,9 +129,11 @@ export default class TextureService {
 		return createdTexture;
 	}
 
-	createEntireTextures(body: EntireTextureToCreate[]): Promise<Textures> {
-		// create textures
-		return Promise.all(body.map((t) => this.createEntireTexture(t)));
+	async createEntireTextures(body: EntireTextureToCreate[]): Promise<Textures> {
+		const res: Textures = [];
+		// must be done synchronously to prevent id collisions
+		for (const tex of body) res.push(await this.createEntireTexture(tex));
+		return res;
 	}
 
 	async changeTexture(id: string, body: TextureCreationParam): Promise<Texture> {

Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,11 @@ export default class TextureService {`
`129`	`129`	`return createdTexture;`
`130`	`130`	`}`
`131`	`131`
`132`		`- createEntireTextures(body: EntireTextureToCreate[]): Promise<Textures> {`
`133`		`- // create textures`
`134`		`- return Promise.all(body.map((t) => this.createEntireTexture(t)));`
	`132`	`+ async createEntireTextures(body: EntireTextureToCreate[]): Promise<Textures> {`
	`133`	`+ const res: Textures = [];`
	`134`	`+ // must be done synchronously to prevent id collisions`
	`135`	`+ for (const tex of body) res.push(await this.createEntireTexture(tex));`
	`136`	`+ return res;`
`135`	`137`	`}`
`136`	`138`
`137`	`139`	`async changeTexture(id: string, body: TextureCreationParam): Promise<Texture> {`