Not a function errors... fn() not a valid function on non-jQuery?

[dovy]

@justincy @jimmyz

I've been scratching my head for a while on this. Finally found a stack-trace for this. In my environment I am using Angular w/o any jQuery. In my compressed file, you can see the stack trace here:
https://cloudup.com/cYEL-fFQe9O
Here's an expanded code block:

            f.prototype.setTimer = function(a, b, c) {
                return c && this.settings.clearTimeout(c),
                this.settings.setTimeout(function() {
                    a()
                }
                , b)
            }
            ,
            f.prototype.setAccessTokenInactiveTimer = function(a) {
                this.accessTokenInactiveTimer = this.setTimer(this.settings.eraseAccessToken, a, this.accessTokenInactiveTimer)
            }

It appears seems that fn() doesn't exist at the time it runs.

It correlates to this line of code:

familysearch-javascript-sdk/src/helpers.js

Lines 80 to 87 in e014974

	Helpers.prototype.setTimer = function(fn, delay, oldTimer) {
	if (oldTimer) {
	clearTimeout(oldTimer);
	}
	setTimeout(function() {
	fn();
	}, delay);
	};

Any ideas? I literally have thousands of these bug reports for this little line. It doesn't affect anything per say, but it may be the reason that chrome sessions don't always expire gracefully.

[justincy]

I think the problem is caused by these lines:

familysearch-javascript-sdk/src/helpers.js

Lines 89 to 95 in e014974

	Helpers.prototype.setAccessTokenInactiveTimer = function(delay) {
	this.accessTokenInactiveTimer = this.setTimer(this.settings.eraseAccessToken, delay, this.accessTokenInactiveTimer);
	};
	Helpers.prototype.setAccessTokenCreationTimer = function(delay) {
	this.accessTokenCreationTimer = this.setTimer(this.settings.eraseAccessToken, delay, this.accessTokenCreationTimer);
	};

this.settings.eraseAccessToken should be this.eraseAccessToken

[dovy]

Deployed. Testing.

[justincy]

We're one step closer. There's a new error now

TypeError: Cannot set property 'accessToken' of undefined

It's caused by this line:

familysearch-javascript-sdk/src/helpers.js

Line 180 in e014974

this.settings.accessToken = null;

I think the problem is due to the eraseAccessToken being passed around in a variable so that when it's called the this context is incorrect. See this jsFiddle for an example: http://jsfiddle.net/90164595/1/

If that's correct then the fix would be to replace this.eraseAccessToken in my previous comment with

this.eraseAccessToken.bind(this);

But bind is only supported by IE 9+. If that's a problem then you can try this:

// In a line above, save a reference to "this"
var self = this;

// Now replace this.eraseAccessToken with this line
function(){ self.eraseAccessToken() };