Skip to content

Current breakage of install due to not specifying dm_control version (or versions for any dependency) #125

Open
@peteflorence

Description

@peteflorence

Hi folks, a few days ago, this worked, given a working underneath mujoco install:

pip install \
  mujoco_py==2.0.2.5 \
  git+https://github.com/rail-berkeley/d4rl@master#egg=d4rl

Although this repo's master branch hasn't been updated since July, the underlying dm_control dependency version is not specified, and it has since updated to mujoco 2.1: google-deepmind/dm_control@420e237

(which doesn't exist publicly yet: https://www.roboti.us/download.html)

This causes the following error when trying to run install d4rl:

Successfully built mujoco-py d4rl mjrl
Failed to build dm-control
Installing collected packages: mujoco-py, mjrl, dm-control, click, d4rl
    Running setup.py install for dm-control ... error
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-p1_maoog/dm-control_a87dbf57bef14d5bb352aa0e2a5bcad6/setup.py'"'"'; __file__='"'"'/tmp/pip-install-p1_maoog/dm-control_a87dbf57bef14d5bb352aa0e2a5bcad6/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-gr13f_14/install-record.txt --single-version-externally-managed --user --prefix= --compile --install-headers /home/peteflorence/.local/include/python3.8/dm-control
         cwd: /tmp/pip-install-p1_maoog/dm-control_a87dbf57bef14d5bb352aa0e2a5bcad6/
    Complete output (2 lines):
    running install
    error: Header file '/home/peteflorence/.mujoco/mujoco210/include/mjdata.h' does not exist.

Could someone add versions to all dependencies here? https://github.com/rail-berkeley/d4rl/blob/master/setup.py

Also, to clarify: although one could wait until mujoco 2.1 is available, it still seems that versioning the benchmark is required, or some other mechanism for not ensuring regressions?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions