Skip to content

Commit 6e529b6

Browse files
Bump ale-py to v0.8.1 (#37)
1 parent 0be00c1 commit 6e529b6

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def get_version():
3434

3535
extras = {
3636
"gym": ["gym>=0.21"],
37-
"atari": ["ale-py~=0.8.0"],
37+
"atari": ["ale-py~=0.8.1"],
3838
# "imageio" should be "gymnasium[mujoco]>=0.26" but there are install conflicts
3939
"dm-control": ["dm-control>=1.0.10", "imageio", "h5py>=3.7.0"],
4040
"dm-control-multi-agent": ["dm-control>=1.0.10", "pettingzoo>=1.22"],

shimmy/utils/envs_configs.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,17 +173,17 @@
173173
"surround",
174174
"tennis",
175175
"tetris",
176-
"tic_tac_toe3_d",
176+
"tic_tac_toe_3d",
177177
"time_pilot",
178178
"trondead",
179179
"turmoil",
180180
"tutankham",
181181
"up_n_down",
182182
"venture",
183183
"video_checkers",
184+
"video_chess",
185+
"video_cube",
184186
"video_pinball",
185-
"videochess",
186-
"videocube",
187187
"wizard_of_wor",
188188
"word_zapper",
189189
"yars_revenge",

tests/test_atari.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,14 @@ def test_all_atari_roms():
3535
],
3636
)
3737
def test_atari_envs(env_id):
38-
"""Tests the atari envs, as there are 1000 possible environment, we only test the Pong variants.
39-
40-
Known environments that fail this test - ALE/TicTacToe3D-v5, ALE/VideoChess-v5, ALE/Videocube-v5 + ram variants.
41-
"""
38+
"""Tests the atari envs, as there are 1000 possible environment, we only test the Pong variants."""
4239
env = gym.make(env_id)
4340

4441
with warnings.catch_warnings(record=True) as caught_warnings:
4542
check_env(env.unwrapped)
4643

44+
env.close()
45+
4746
for warning_message in caught_warnings:
4847
assert isinstance(warning_message.message, Warning)
4948
if warning_message.message.args[0] not in CHECK_ENV_IGNORE_WARNINGS:

0 commit comments

Comments
 (0)