simple-coding/4-iffy-function.php at main · FarzinBidokhti/simple-coding · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
<?php

function myFunction($a)
{
    // Problem
    if ($a > 11) {
        echo 'some code ...';
        echo 'some code ...';
        echo 'some code ...';
        echo 'some code ...';
        if ($a > 14) {
            echo "some code ...";
            echo "some code ...";
            echo "some code ...";
        }
        echo 'some code ...';
        echo 'some code ...';
        echo 'some code ...';
    }

    // Solution
    if ($a <= 11) {
        return null;
    }

    echo 'some code ...';
    echo 'some code ...';
    echo 'some code ...';
    echo 'some code ...';
    if ($a > 14) {
        echo "some code ...";
        echo "some code ...";
        echo "some code ...";
    }
    echo 'some code ...';
    echo 'some code ...';
    echo 'some code ...';
}

// NOTE: When we don't specific return for function, the function by default return null.