Skip to content

support 32-bit hashes #44

@RaduBerinde

Description

@RaduBerinde

The memory used to accumulate the hashes, as well as the memory used by NewBinaryFuse can be an issue. In Pebble (CockroachDB), we use 32-bit hashes to save on memory when building bloom filters (approach inherited from RocksDB).

Would it be acceptable to modify the library to accept both uint32 and uint64 keys? We could define a type Key { ~uint32 | ~uint64 }. I can work on a patch, but wanted to check if it would be accepted before I start.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions