Skip to content
This repository was archived by the owner on Feb 21, 2024. It is now read-only.

Commit 00f5a15

Browse files
authored
Merge pull request #1310 from codysoyland/http-handler-close-redux-0.10
Close HTTP handler gracefully (Fixes #1018) (v0.10)
2 parents 03e2570 + 8aec16a commit 00f5a15

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

server.go

+7-2
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,13 @@ func (s *Server) Open() error {
307307

308308
// Serve HTTP.
309309
go func() {
310-
err := http.Serve(s.ln, s.handler)
311-
if err != nil {
310+
server := &http.Server{Handler: s.handler}
311+
go func() {
312+
<-s.closing
313+
server.Close()
314+
}()
315+
err := server.Serve(s.ln)
316+
if err != nil && err.Error() != "http: Server closed" {
312317
s.logger.Printf("HTTP handler terminated with error: %s\n", err)
313318
}
314319
}()

0 commit comments

Comments
 (0)