fix(macos): reject incomplete explicit theme dirs (#25)

Treat an explicit --theme-dir as authoritative and fail when theme.json is missing instead of silently falling back to bundled demo assets.

Adds exact regression coverage and user-facing release notes.

Fixes #15.

Author: nightt5879

macos/CHANGELOG.md

@@ -8,6 +8,7 @@
 - 更新主题配置往返测试：安装只备份外观键，不再错误断言强制切换深色模式
 - 恢复原本没有 `[desktop]` 配置段的用户设置时，不再额外写入空段
 - 热切换读取运行状态时复用 Codex 内置 Node.js，不再依赖系统 `python3` 或执行 `eval`
+- 显式传入的 `--theme-dir` 缺少 `theme.json` 时立即报错，不再静默回退到内置 demo 主题
 
 ---
 

macos/scripts/injector.mjs

@@ -203,19 +203,18 @@ async function connectCodexTargets(port, timeoutMs) {
 }
 
 async function loadTheme(themeDir) {
-  const defaultAssetsRoot = path.join(root, "assets");
-  let assetsRoot = defaultAssetsRoot;
-  if (themeDir) {
-    try {
-      await fs.access(path.join(themeDir, "theme.json"));
-      assetsRoot = themeDir;
-    } catch (error) {
-      if (error.code !== "ENOENT") throw error;
+  const assetsRoot = themeDir ?? path.join(root, "assets");
+  const configPath = path.join(assetsRoot, "theme.json");
+  let config;
+  try {
+    config = await fs.readFile(configPath, "utf8");
+  } catch (error) {
+    if (themeDir && error.code === "ENOENT") {
+      throw new Error(`Explicit theme directory is missing theme.json: ${configPath}`);
     }
+    throw error;
   }
-
-  const configPath = path.join(assetsRoot, "theme.json");
-  const raw = JSON.parse(await fs.readFile(configPath, "utf8"));
+  const raw = JSON.parse(config);
   if (raw.schemaVersion !== 1 || typeof raw.image !== "string" || !raw.image) {
     throw new Error(`${configPath} has an unsupported schema or image field`);
   }

macos/tests/run-tests.sh

@@ -70,6 +70,15 @@ PAYLOAD_JSON="$("$NODE" "$ROOT/scripts/injector.mjs" --check-payload --theme-dir
   const value = JSON.parse(process.argv[1]);
   if (!value.pass || value.themeName !== "测试主题" || value.imageBytes < 1) process.exit(1);
 ' "$PAYLOAD_JSON"
+/bin/mkdir -p "$TMP/missing-theme"
+if MISSING_THEME_OUTPUT="$(
+  "$NODE" "$ROOT/scripts/injector.mjs" --check-payload --theme-dir "$TMP/missing-theme" 2>&1
+)"; then
+  printf 'Explicit theme directory without theme.json unexpectedly passed.\n' >&2
+  exit 1
+fi
+/usr/bin/printf '%s\n' "$MISSING_THEME_OUTPUT" | /usr/bin/grep -F -q \
+  "Explicit theme directory is missing theme.json: $TMP/missing-theme/theme.json"
 "$NODE" "$ROOT/scripts/write-theme.mjs" reset-demo --output-dir "$TMP/theme" >/dev/null
 [ ! -e "$TMP/theme" ]