Skip to content

Commit 5242d74

Browse files
committed
merge: sync verified updater with v1.5.14
2 parents 5da5ff2 + 95423d8 commit 5242d74

55 files changed

Lines changed: 5608 additions & 602 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

TASK_PROGRESS.md

Lines changed: 138 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
App bundle ID, App/engine version, and code-signature integrity. Only the
2323
verified DMG is moved into a private cache and opened; the running App is
2424
never replaced automatically. Background checks still do not download.
25-
- [verified] Live v1.5.12 metadata check, shell syntax, `git diff --check`, Swift
25+
- [verified historical] Live v1.5.12 metadata check, shell syntax, `git diff --check`, Swift
2626
frontend parse, shared-runtime sync check, 93 portable Node tests, and the
2727
macOS suite all pass. The macOS suite covers the valid handoff plus checksum,
2828
identity, URL, duplicate asset, draft Release, cache symlink, oversized
@@ -34,13 +34,144 @@
3434
`cixiangtao:codex/verified-auto-update`; Draft PR #355 targets
3535
`Fei-Away/Codex-Dream-Skin:main`:
3636
https://github.com/Fei-Away/Codex-Dream-Skin/pull/355
37-
- [current] Waiting for the Draft PR's macOS CI to provide the full
38-
SwiftPM/XCTest and packaged-DMG evidence unavailable on this machine.
39-
- [pending] A real newer public Release does not exist yet, so clicking the
40-
menu through a production download/open flow remains a post-release smoke
41-
test; automated tests never launch an installer. Keep this PR scoped to the
42-
macOS guided handoff and do not fold #276 or #237 into it.
37+
- [sync 2026-08-14] Upstream advanced by five commits to public v1.5.14 and
38+
Draft PR #355 became conflicting. The published PR branch is being repaired
39+
with a non-rewriting merge from `upstream/main@95423d8`; no rebase or force
40+
push is allowed. The verified download flow is being adapted to the new
41+
bilingual macOS catalog while preserving bundled-updater preference and the
42+
fail-closed validation contract.
43+
- [verified 2026-08-14] Both content conflicts are resolved semantically. Live
44+
metadata reports current/latest v1.5.14; portable Node passes 104/104, macOS
45+
localization passes 6/6, runtime asset sync and both payload checks pass, all
46+
six version sources equal 1.5.14, Bash/Swift parse and direct Swift typecheck
47+
pass, and the complete macOS wrapper exits 0. The wrapper intentionally skips
48+
full-Xcode SwiftPM/XCTest, signed-runtime integration, and Doctor on this host;
49+
the guided-DMG positive and fail-closed negative cases still execute.
50+
- [handoff 2026-08-14] The full merge delta against `upstream/main` is the
51+
reviewed result for one focused merge commit and normal push to the existing
52+
Draft PR; exact-head upstream CI remains the next external gate.
53+
- [pending] Require exact-head upstream CI after push. A real newer public
54+
Release does not exist yet, so the production menu-to-newer-release download
55+
remains a post-release smoke test; automated tests never launch an installer.
56+
Keep this PR scoped to the macOS guided handoff and do not fold #276 or #237
57+
into it.
4358

59+
## Issue #352 fix and v1.5.14 release (2026-08-12)
60+
61+
- [fix merged] PR #360 (`e3787857953998a1916c39b10942ac6c15978a25`) passed exact-head CI run `31558654733`: Static, macOS repository regressions plus universal DMG, Windows PowerShell 7, and Windows PowerShell 5.1 plus Setup.exe. It was squash-merged with the authorized same-owner review bypass at `2026-08-12T03:06:37Z` as `main@69a5a2e4b68174b1c0c70a2fa62adf1aca1eff2a`.
62+
- [release branch] This isolated worktree is `codex/release-v1.5.14` from that exact merge commit. Only the six version sources, two version-bound macOS assertions, both platform changelogs, and this durable progress record are in scope. All six version sources equal `1.5.14`.
63+
- [local gate] Portable Node regressions pass 103/103; runtime asset sync, macOS/Windows payload checks, Node/Bash syntax, version consistency, and `git diff --check` pass. `CODEX_DREAM_SKIN_SKIP_DOCTOR=1 bash macos/tests/run-tests.sh` passes with only the documented full-Xcode XCTest and installed signed Codex Doctor branches skipped.
64+
- [next] Commit and push the version branch, open a Ready PR, require exact-head CI, merge it, then verify the sole Release workflow creates `v1.5.14` from the exact main merge and publishes non-empty DMG, Setup.exe, and `SHA256SUMS.txt`. Only after public asset/checksum verification will #352 receive the customer reply; keep it open pending field confirmation.
65+
66+
## Issue #352 Windows one-click cold-session baseline (2026-08-12)
67+
68+
- [root cause] The reporter's exact `One-click apply requires an existing
69+
verified Dream Skin session.` failure is the cold-session guard introduced
70+
by PR #245 (`c44b434`, merged as `71f30f0`), not PR #357. The guard conflicts
71+
with the documented one-click start/restart path by rejecting before that
72+
path can run. Upstream Issue #235 remains a separate limitation: current
73+
Store Codex may still fail to expose a verified CDP endpoint after startup.
74+
- [local implementation] Isolated worktree
75+
`/private/tmp/dreamskin-issue352-baseline`, branch
76+
`codex/fix-352-one-click-baseline`, starts from exact public v1.5.13
77+
`main@6ae42e645c15f6ac91f5fa54a9c37dbc57af646c`. The Windows community apply
78+
path now classifies only a missing session as bootstrap-eligible, releases
79+
the operation lock while invoking the existing start-and-verify child, then
80+
reacquires the lock and revalidates the complete old-theme baseline and its
81+
fingerprint. All other baseline failures remain fail-closed.
82+
- [safety/order] User confirmation still precedes startup. Old-theme baseline
83+
establishment and visible verification precede temporary work-root creation,
84+
ZIP download, import, snapshot, or active-theme write. The transaction keeps
85+
its second baseline check to reject a concurrent pause/theme/session change.
86+
A baseline failure therefore performs zero candidate download/import/write,
87+
and no longer claims that nonexistent download files were cleaned up.
88+
- [tests] Before the final orchestration assertion, focused PowerShell suites passed for community apply, both appearance
89+
recovery paths, renderer readiness, verified-skin preservation, config
90+
rollback, and the structured start-result contract. All 11 Windows scripts
91+
parse; Windows Node tests pass 27/27, tools Node tests 2/2, and the focused
92+
macOS ZIP validator passes. The final portable Node set passes 103/103,
93+
runtime asset sync, dual payload checks, Node syntax, and `git diff --check`
94+
pass. The portable macOS set previously passed 73/74 in one
95+
parallel run with only a host subprocess exit 141, and that exact ZIP case
96+
passed alone. Full Windows wrapper and one ZIP guard remain native-Windows CI
97+
gates because macOS lacks `Get-AuthenticodeSignature` and resolves `/var`
98+
through a symlink. This shell no longer has `pwsh` installed, so the final
99+
test-only orchestration ordering assertion has not been executed locally and
100+
remains an explicit exact-head Windows CI gate.
101+
- [independent review] Final read-only review found no P0/P1. It confirmed
102+
lock release before child startup, bounded lock reacquisition, exact
103+
fingerprint revalidation, download-before-baseline prevention, accurate
104+
cleanup messaging, and PowerShell 5.1-compatible syntax. Residual evidence
105+
required before merge is exact-head Windows PowerShell 5.1/7 CI plus Setup.
106+
- [current truth] Six implementation/test/documentation/progress files are modified and
107+
uncommitted. No push, PR, merge, version bump, tag, Release, or Issue reply
108+
exists for this fix yet. Next: rerun the corrected focused/static gates,
109+
review the final diff, commit/push, open a Ready PR, and require all four
110+
exact-head CI jobs before merge. Then prepare v1.5.14 through the sole Release
111+
workflow, verify tag/assets/checksums/public status, and reply to #352 without
112+
closing it until the reporter confirms the field fix.
113+
114+
## Issue #354 Windows failed-start appearance recovery (2026-08-12)
115+
116+
- [current local implementation] All prior independent-audit findings are
117+
addressed. Startup appearance uses a strict, 64 KiB durable
118+
`preparing -> committed` journal before marker/config writes. Recovery is
119+
three-way per managed key and marker, preserves a newer post-crash user
120+
`system -> light` edit, rejects a journal whose declared changes do not match
121+
its snapshots without mutating config/marker/evidence, and normalizes CRLF
122+
snapshot line endings before serialization. One-click child completion gets
123+
lock timeout plus 300000 ms independent grace, never force-kills a live child,
124+
and keeps candidate files coherent for timeout/invalid/blocked/
125+
`preserved-rendered` states. A rendered-but-unverified result-token child
126+
closes its exact new CDP session and restores appearance before returning
127+
`restored`.
128+
- [focused verification 2026-08-12] Seven PowerShell 7.6.4 suites pass together:
129+
`config-startup-rollback`, `start-result-contract`, CDP-failure recovery,
130+
post-launch recovery, renderer readiness, verified-skin preservation, and
131+
`community-theme-link`. Executable coverage includes marker/config hard-stop
132+
windows, tampered journals, CRLF quoted keys and dollar-bearing values,
133+
post-crash user edits, 480000 ms parent wait, no force-kill/result cleanup
134+
while the child remains live, preserved-rendered file coherence, and the full
135+
outer child catch/writer/reader category path.
136+
- [complete local gate 2026-08-12] Portable Node passes 103/103 (macOS 74,
137+
Windows 27, tools 2). All 23 PowerShell files parse and satisfy the PS5.1
138+
non-ASCII UTF-8 BOM policy; all Node and Bash syntax checks, both platform
139+
payload checks, runtime asset sync, and `git diff --check` pass. The full
140+
`CODEX_DREAM_SKIN_SKIP_DOCTOR=1 bash macos/tests/run-tests.sh` wrapper exits
141+
0, including signed-runtime switch and runtime-state integration. Native
142+
SwiftPM/XCTest is skipped because this host lacks a matching full Xcode
143+
platform, and Doctor is explicitly skipped because no installed signed Codex
144+
app is available. Native Windows PowerShell 5.1/7 and Setup remain CI gates.
145+
- [independent final audit] Read-only review of the complete local diff found no
146+
remaining P0/P1. The prior parent hard-kill and `preserved-rendered` mixed-state
147+
blockers are closed by executable production-helper/result-path coverage.
148+
Non-blocking P2 residuals are documented: same-user coherent rewriting of the
149+
entire local journal is outside corruption detection; the explicitly invoked
150+
test/debug-only `-ForegroundInjector` mode has a narrow pre-injector committed
151+
window and no production caller; and a concurrent manual action choosing
152+
byte-identical theme content is indistinguishable from no superseding change.
153+
- [remote state] PR #351 is squash-merged as
154+
`main@9e6798700c0e35be0713135ebd9b3a6f01583499`; exact-head run
155+
`31522162828` and post-merge run `31523222468` passed all four client CI
156+
jobs. Draft PR #357 targets that `main` from
157+
`codex/fix-354-appearance-rollback@fa3e53822a4158d56dc1ae10efa8f288b2d73a88`.
158+
Exact-head run `31531028135` passed Static, macOS/DMG, Windows PowerShell 7,
159+
and Windows PowerShell 5.1/Setup.
160+
- [pushed checkpoint] The 15 implementation, test, and Windows documentation
161+
files are committed as `54933c3678034333a4e00c0a93c9d4da5d2ded6d`; the
162+
first verification checkpoint is `8ad35f2`. Both were pushed to
163+
`codex/fix-354-appearance-rollback` for Draft PR #357. Run `31531028135`
164+
remains historical evidence for older head `fa3e538`, not the new changes.
165+
- [scope] The PR fixes only caught Windows failed-start partial appearance,
166+
rollback ownership/concurrency, and bounded one-click diagnostics. It does
167+
not claim that official Store Codex `26.803.5235.0` restored a supported CDP
168+
endpoint. User authorization covers scoped commit, push, PR merge, and issue
169+
handling, but not a version, tag, Release, deployment, or external config.
170+
- [remaining] Push this progress-only checkpoint and update the PR body. Require
171+
all four CI jobs green on the resulting exact head before marking #357 Ready
172+
and squash-merging with head protection. Verify post-merge `main` CI, then
173+
update only #235, #352, and #354. Native Windows 5.1/7 and Setup are CI-only
174+
evidence on this macOS host.
44175
## Client release v1.5.12 (2026-08-08)
45176

46177
- [scope] Reviewed and merged 10 pending community/self PRs that had accumulated

0 commit comments

Comments
 (0)