[codex] fix Codex 26.727 Settings renderer detection (#334)

* fix Codex 26.727 settings renderer detection

* test: make bootstrap contract line-ending independent

* docs: record PR 334 CI follow-up

Author: Fei-Away

TASK_PROGRESS.md

@@ -1,5 +1,31 @@
 # Task Progress
 
+## PR #334 Windows CRLF CI follow-up — locally verified (2026-08-01)
+
+- [scope] Client worktree `/private/tmp/dreamskin-settings-fix.4tH4ld` is on
+  `codex/fix-26-727-settings-renderer`; PR #334 targets `main`. The pre-fix PR
+  head is `159c650c3b43877df4413a7b0a20562fe556a018`.
+- [reproduced from CI] Run `30646840223` passed Static checks and macOS
+  repository regressions, but both Windows PowerShell 5.1 and PowerShell 7 jobs
+  failed in their regression suite. On the Windows CRLF checkout, the bootstrap
+  source-contract test's fixed 2,200-character slice ended at
+  `setInterval(in`, before the asserted `setInterval(install, 250)` text.
+- [fixed locally/tests only] Both platform bootstrap tests now inspect the
+  complete string returned by the already imported
+  `earlyPayloadFor("", "source-contract")`. This removes line-ending-dependent
+  truncation without changing or weakening the early-injection assertions and
+  without changing runtime implementation.
+- [verified locally] `node macos/tests/injector-bootstrap.test.mjs`,
+  `node windows/tests/injector-bootstrap.test.mjs`, both platform
+  `renderer-inject.test.mjs` tests, `node tools/doctor-selectors.test.mjs`, and
+  `git diff --check` all pass.
+- [committed/pushed] Test-only fix commit
+  `7d19780ec56446c3d1bd1ac61931588c5487f55f` is pushed to
+  `origin/codex/fix-26-727-settings-renderer` for PR #334.
+- [pending] Require a fresh exact-head CI pass for all four jobs before merge.
+  No merge, release, deployment, Issue reply, or Issue closure has occurred in
+  this follow-up.
+
 ## Client release v1.5.10 — in progress (2026-07-31)
 
 - [base] Feature PR #324 was squash-merged to `main` at

macos/assets/renderer-inject.js

@@ -1,6 +1,6 @@
 // Canonical cross-platform renderer. Run tools/sync-runtime-assets.mjs after editing.
 ((cssText, artDataUrl, themeConfig) => {
-  const SELECTOR_CONTRACT = {"schema":"codex-dream-skin-selectors/1","selectors":[{"key":"shell-main","selector":"main:is(.main-surface, [data-app-shell-main-surface], [class*=\"_MainContentSurface_\"])","tier":"L1","scope":"all","required":true},{"key":"left-panel","selector":"aside.app-shell-left-panel","tier":"L1","scope":"all","required":true},{"key":"header-tint","selector":"header:is(.app-header-tint, [data-app-shell-header-edge-scroll], [class*=\"_Header_\"])","tier":"L1","scope":"all","required":true},{"key":"main-content-top-fade","selector":":is(.app-shell-main-content-top-fade, [data-app-shell-main-content-top-fade], [class*=\"_MainContentTopFade_\"])","tier":"L2","scope":"all","required":false},{"key":"home-icon","selector":"[data-testid=\"home-icon\"]","tier":"L1","scope":"home","required":true},{"key":"home-route","selector":"[role=\"main\"]:has([data-testid=\"home-icon\"])","tier":"L1","scope":"home","required":true},{"key":"home-route-css","selector":"[role=\"main\"]","tier":"L1","scope":"home","required":true},{"key":"home-banners","selector":".home-banners","tier":"L2","scope":"home","required":false},{"key":"composer-chrome","selector":".composer-surface-chrome","tier":"L2","scope":"home+thread","required":false},{"key":"composer-toolbar","selector":".composer-surface-chrome [class*=\"_footer_\"]","tier":"L2","scope":"home+thread","required":false},{"key":"home-utility","selector":"[class*=\"_homeUtilityBar_\"]","tier":"L2","scope":"home","required":false},{"key":"game-source","selector":"[data-feature=\"game-source\"]","tier":"L2","scope":"home","required":false},{"key":"home-suggestions","selector":".group\\/home-suggestions","tier":"L2","scope":"home","required":false},{"key":"project-selector","selector":".group\\/project-selector","tier":"L2","scope":"home config","required":false},{"key":"markdown","selector":"[class*=\"_markdown\"]","tier":"L2","scope":"thread","required":false},{"key":"thread-surface","selector":".thread-scroll-container","tier":"L2","scope":"thread","required":false},{"key":"message","selector":":is([data-message-author-role], [data-local-conversation-user-anchor], [data-local-conversation-final-assistant])","tier":"L2","scope":"thread","required":false},{"key":"appearance-radio","selector":"input[name=\"appearance-theme\"]","tier":"L2","scope":"settings","required":false},{"key":"overlay-menu","selector":"[role=\"menu\"]","tier":"L2","scope":"overlay","required":false},{"key":"overlay-dialog","selector":"[role=\"dialog\"]","tier":"L2","scope":"overlay","required":false},{"key":"overlay-popper","selector":"[data-radix-popper-content-wrapper]","tier":"L2","scope":"overlay","required":false}],"stableTestids":["app-shell-header-context-menu-surface","home-icon","theme-preview"]};
+  const SELECTOR_CONTRACT = {"schema":"codex-dream-skin-selectors/1","selectors":[{"key":"shell-main","selector":"main:is(.main-surface, [data-app-shell-main-surface], [class*=\"_MainContentSurface_\"])","tier":"L1","scope":"all","required":true},{"key":"left-panel","selector":"aside.app-shell-left-panel","tier":"L1","scope":"all","required":true},{"key":"header-tint","selector":"header:is(.app-header-tint, [data-app-shell-header-edge-scroll], [class*=\"_Header_\"])","tier":"L1","scope":"all","required":true},{"key":"main-content-top-fade","selector":":is(.app-shell-main-content-top-fade, [data-app-shell-main-content-top-fade], [class*=\"_MainContentTopFade_\"])","tier":"L2","scope":"all","required":false},{"key":"home-icon","selector":"[data-testid=\"home-icon\"]","tier":"L1","scope":"home","required":true},{"key":"home-route","selector":"[role=\"main\"]:has([data-testid=\"home-icon\"])","tier":"L1","scope":"home","required":true},{"key":"home-route-css","selector":"[role=\"main\"]","tier":"L1","scope":"home","required":true},{"key":"home-banners","selector":".home-banners","tier":"L2","scope":"home","required":false},{"key":"composer-chrome","selector":".composer-surface-chrome","tier":"L2","scope":"home+thread","required":false},{"key":"composer-toolbar","selector":".composer-surface-chrome [class*=\"_footer_\"]","tier":"L2","scope":"home+thread","required":false},{"key":"home-utility","selector":"[class*=\"_homeUtilityBar_\"]","tier":"L2","scope":"home","required":false},{"key":"game-source","selector":"[data-feature=\"game-source\"]","tier":"L2","scope":"home","required":false},{"key":"home-suggestions","selector":".group\\/home-suggestions","tier":"L2","scope":"home","required":false},{"key":"project-selector","selector":".group\\/project-selector","tier":"L2","scope":"home config","required":false},{"key":"markdown","selector":"[class*=\"_markdown\"]","tier":"L2","scope":"thread","required":false},{"key":"thread-surface","selector":".thread-scroll-container","tier":"L2","scope":"thread","required":false},{"key":"message","selector":":is([data-message-author-role], [data-local-conversation-user-anchor], [data-local-conversation-final-assistant])","tier":"L2","scope":"thread","required":false},{"key":"settings-panel","selector":"[data-settings-panel-slug=\"general-settings\"]","tier":"L2","scope":"settings","required":false},{"key":"appearance-radio","selector":"input[name=\"appearance-theme\"]","tier":"L2","scope":"settings","required":false},{"key":"overlay-menu","selector":"[role=\"menu\"]","tier":"L2","scope":"overlay","required":false},{"key":"overlay-dialog","selector":"[role=\"dialog\"]","tier":"L2","scope":"overlay","required":false},{"key":"overlay-popper","selector":"[data-radix-popper-content-wrapper]","tier":"L2","scope":"overlay","required":false}],"stableTestids":["app-shell-header-context-menu-surface","home-icon","theme-preview"]};
   const STATE_KEY = "__CODEX_DREAM_SKIN_STATE__";
   const DISABLED_KEY = "__CODEX_DREAM_SKIN_DISABLED__";
   const STYLE_REGISTRY_KEY = "__CODEX_DREAM_SKIN_STYLE_SHEETS__";
@@ -678,7 +678,8 @@
     const overlay = selectorHit("overlay-menu") || selectorHit("overlay-dialog") ||
       selectorHit("overlay-popper");
     let baseState = "thread";
-    if (selectorHit("appearance-radio") || stableTestidHit("theme-preview")) baseState = "settings";
+    if (selectorHit("settings-panel") || selectorHit("appearance-radio") ||
+      stableTestidHit("theme-preview")) baseState = "settings";
     else if (selectorHit("home-icon") || selectorHit("home-route")) baseState = "home";
     else if (!selectorHit("shell-main") && !document.querySelector('main, [role="main"]')) baseState = "settings";
     const missingL1 = SELECTOR_CONTRACT.selectors

macos/assets/selectors.json

@@ -44,7 +44,8 @@
     { "key": "markdown", "selector": "[class*=\"_markdown\"]", "tier": "L2", "scope": "thread", "required": false, "notes": "会话内容块，单页可达 100+ 个，样式规则注意性能" },
     { "key": "thread-surface", "selector": ".thread-scroll-container", "tier": "L2", "scope": "thread", "required": false, "notes": "会话滚动表面；双端活动会话快照均存在" },
     { "key": "message", "selector": ":is([data-message-author-role], [data-local-conversation-user-anchor], [data-local-conversation-final-assistant])", "tier": "L2", "scope": "thread", "required": false, "notes": "用户与助手消息的稳定语义边界；兼容旧版 role 属性和 Codex 26.727.4816 的用户/助手语义属性，运行时对子节点变更做合并刷新" },
-    { "key": "appearance-radio", "selector": "input[name=\"appearance-theme\"]", "tier": "L2", "scope": "settings", "required": false, "notes": "外观三选一；theme-preview testid 同屏出现" },
+    { "key": "settings-panel", "selector": "[data-settings-panel-slug=\"general-settings\"]", "tier": "L2", "scope": "settings", "required": false, "notes": "Codex 26.727 设置页稳定导航锚点；设置页可先落在 General，不再保证 appearance-theme 或 theme-preview 存在" },
+    { "key": "appearance-radio", "selector": "input[name=\"appearance-theme\"]", "tier": "L2", "scope": "settings", "required": false, "notes": "旧版外观三选一；新设置页可能仅有 settings-panel" },
     { "key": "overlay-menu", "selector": "[role=\"menu\"]", "tier": "L2", "scope": "overlay", "required": false },
     { "key": "overlay-dialog", "selector": "[role=\"dialog\"]", "tier": "L2", "scope": "overlay", "required": false },
     { "key": "overlay-popper", "selector": "[data-radix-popper-content-wrapper]", "tier": "L2", "scope": "overlay", "required": false }

macos/scripts/injector.mjs

@@ -522,7 +522,8 @@ async function probeSession(session) {
       main: Boolean(document.querySelector(${selectorLiteral("home-route")})),
       generic: genericCodexSurface(),
     };
-    const settings = Boolean(document.querySelector(${selectorLiteral("appearance-radio")})) ||
+    const settings = Boolean(document.querySelector(${selectorLiteral("settings-panel")})) ||
+      Boolean(document.querySelector(${selectorLiteral("appearance-radio")})) ||
       Boolean(document.querySelector(${stableTestidLiteral("theme-preview")}));
     return {
       markers,
@@ -1154,6 +1155,7 @@ async function verifySession(session, expectedThemeId = null, expectedRevision =
     const genericMain = box(document.querySelector('[data-ds-part="main"], [data-ds-part="home"]'));
     const genericInput = box(document.querySelector('[data-ds-part="composer"]'));
     const settingsBoxes = [
+      box(document.querySelector(${selectorLiteral("settings-panel")})),
       box(document.querySelector(${selectorLiteral("appearance-radio")})),
       box(document.querySelector(${stableTestidLiteral("theme-preview")})),
     ];
@@ -1406,7 +1408,8 @@ export function earlyPayloadFor(payload, revision) {
       const shell = document.querySelector(${selectorLiteral("shell-main")});
       const sidebar = document.querySelector(${selectorLiteral("left-panel")});
       const main = document.querySelector(${selectorLiteral("home-route")});
-      const settings = document.querySelector(${selectorLiteral("appearance-radio")}) ||
+      const settings = document.querySelector(${selectorLiteral("settings-panel")}) ||
+        document.querySelector(${selectorLiteral("appearance-radio")}) ||
         document.querySelector(${stableTestidLiteral("theme-preview")});
       const genericMain = document.querySelector('main, [role="main"]');
       const genericInput = document.querySelector('textarea, [contenteditable="true"], [role="textbox"]');

macos/tests/injector-bootstrap.test.mjs

@@ -20,6 +20,7 @@ function createFixture() {
     shell: false,
     sidebar: false,
     main: false,
+    settingsPanel: false,
     settings: false,
     genericInput: false,
     branding: false,
@@ -36,6 +37,9 @@ function createFixture() {
         if (selector === "aside.app-shell-left-panel") return markers.sidebar ? {} : null;
         if (selector === "[role=\"main\"]") return markers.main ? {} : null;
         if (selector === "main, [role=\"main\"]") return markers.main ? {} : null;
+        if (selector === '[data-settings-panel-slug="general-settings"]') {
+          return markers.settingsPanel ? {} : null;
+        }
         if (selector.includes("textarea") || selector.includes("contenteditable") || selector.includes("textbox")) {
           return markers.genericInput ? {} : null;
         }
@@ -96,6 +100,16 @@ generic.tick();
 assert.deepEqual(generic.context.window.installs, ["generic"],
   "A verified app:// Codex surface with generic main/input anchors must accept newer renderer shells.");
 
+const settingsPanel = createFixture();
+vm.runInNewContext(
+  earlyPayloadFor('window.installs.push("settings-panel")', "settings-panel"),
+  settingsPanel.context,
+);
+settingsPanel.markers.settingsPanel = true;
+settingsPanel.tick();
+assert.deepEqual(settingsPanel.context.window.installs, ["settings-panel"],
+  "Codex 26.727 Settings must accept its stable general-settings panel without legacy appearance controls.");
+
 const generations = createFixture();
 generations.makeNotReady();
 generations.markers.shell = true;
@@ -111,9 +125,7 @@ assert.deepEqual(
 );
 assert.equal(generations.context.window.__CODEX_DREAM_SKIN_EARLY_APPLIED__, "new");
 
-const earlyStart = source.indexOf("export function earlyPayloadFor");
-const earlySource = source.slice(earlyStart, earlyStart + 2200);
-assert.ok(earlyStart >= 0, "Early payload helper must remain exported for bootstrap tests.");
+const earlySource = earlyPayloadFor("", "source-contract");
 assert.doesNotMatch(earlySource, /MutationObserver|childList|subtree/,
   "Early bootstrap must not observe the entire renderer DOM.");
 assert.doesNotMatch(earlySource, /document\.title|document\.body\?\.innerText|location\.href/,
@@ -123,6 +135,46 @@ assert.match(earlySource, /setInterval\(install, 250\)/);
 const identityProbeStart = source.indexOf("async function probeSession");
 const identityProbeSource = source.slice(identityProbeStart, identityProbeStart + 1800);
 assert.ok(identityProbeStart >= 0, "The live target probe must remain covered by the identity test.");
+const probePrefix = "return session.evaluate(`";
+const probePayloadStart = source.indexOf(probePrefix, identityProbeStart) + probePrefix.length;
+const probePayloadEnd = source.indexOf("`);", probePayloadStart);
+assert.ok(probePayloadStart >= probePrefix.length && probePayloadEnd > probePayloadStart,
+  "The live identity expression must remain extractable for behavioral testing.");
+const probeTemplate = source.slice(probePayloadStart, probePayloadEnd);
+assert.doesNotMatch(probeTemplate, /`/, "The live identity expression must not contain nested template literals.");
+const liveProbePayload = vm.runInNewContext(`\`${probeTemplate}\``, {
+  selectorLiteral: (key) => JSON.stringify(`[selector-${key}]`),
+  stableTestidLiteral: (key) => JSON.stringify(`[data-testid="${key}"]`),
+});
+const runLiveProbe = ({
+  protocol = "app:", settingsPanel: hasSettingsPanel = false,
+  genericMain = false, genericInput = false, branding = false,
+} = {}) => vm.runInNewContext(liveProbePayload, {
+  location: { protocol },
+  document: {
+    querySelector(selector) {
+      if (selector === "[selector-settings-panel]") return hasSettingsPanel ? {} : null;
+      if (selector === 'main, [role="main"]') return genericMain ? {} : null;
+      if (selector === 'textarea, [contenteditable="true"], [role="textbox"]') {
+        return genericInput ? {} : null;
+      }
+      if (selector === '[data-testid="app-shell-header-context-menu-surface"]') {
+        return branding ? {} : null;
+      }
+      return null;
+    },
+  },
+});
+assert.equal(runLiveProbe({ settingsPanel: true }).codex, true,
+  "The live probe must accept the Codex 26.727 general Settings panel on app://.");
+assert.equal(runLiveProbe({ protocol: "https:", settingsPanel: true }).codex, false,
+  "The Settings marker must never identify a non-app target.");
+assert.equal(runLiveProbe({ genericMain: true, genericInput: true }).codex, false,
+  "The live probe must reject an unbranded generic app target.");
+assert.equal(runLiveProbe({ genericMain: true, genericInput: true, branding: true }).codex, true,
+  "The live probe may accept generic anchors only with the stable Codex branding marker.");
+assert.match(identityProbeSource, /selectorLiteral\("settings-panel"\)/,
+  "The live probe must retain the current Settings structural marker.");
 assert.match(identityProbeSource, /return Boolean\(main && input && branded\)/,
   "The live target probe must require branding together with both generic anchors.");
 assert.match(identityProbeSource, /app-shell-header-context-menu-surface/,

runtime/renderer-inject.js

@@ -678,7 +678,8 @@
     const overlay = selectorHit("overlay-menu") || selectorHit("overlay-dialog") ||
       selectorHit("overlay-popper");
     let baseState = "thread";
-    if (selectorHit("appearance-radio") || stableTestidHit("theme-preview")) baseState = "settings";
+    if (selectorHit("settings-panel") || selectorHit("appearance-radio") ||
+      stableTestidHit("theme-preview")) baseState = "settings";
     else if (selectorHit("home-icon") || selectorHit("home-route")) baseState = "home";
     else if (!selectorHit("shell-main") && !document.querySelector('main, [role="main"]')) baseState = "settings";
     const missingL1 = SELECTOR_CONTRACT.selectors

tools/doctor-selectors.mjs

@@ -95,7 +95,8 @@ function pageDoctor(selectors, stableTestids = []) {
   const overlay = count("overlay-menu") > 0 || count("overlay-dialog") > 0 ||
     count("overlay-popper") > 0;
   let baseState = "thread";
-  if (count("appearance-radio") > 0 || stableTestidCount("theme-preview") > 0) baseState = "settings";
+  if (count("settings-panel") > 0 || count("appearance-radio") > 0 ||
+    stableTestidCount("theme-preview") > 0) baseState = "settings";
   else if (count("home-icon") > 0 || count("home-route") > 0) baseState = "home";
   else if (count("shell-main") === 0) baseState = "settings";
 

tools/doctor-selectors.test.mjs

@@ -27,6 +27,11 @@ assert.equal(
   ':is([data-message-author-role], [data-local-conversation-user-anchor], [data-local-conversation-final-assistant])',
   "The message contract must bridge both legacy and Codex 26.727 role boundaries.",
 );
+assert.equal(
+  selectorFor("settings-panel"),
+  '[data-settings-panel-slug="general-settings"]',
+  "The Settings contract must use the stable Codex 26.727 general-settings panel marker.",
+);
 const resultFor = (baseState, hits, overlay = false) => gradeDoctorResult(contract, {
   baseState,
   overlay,
@@ -46,10 +51,12 @@ const brokenHome = resultFor("home", ["shell-main", "left-panel", "header-tint",
 assert.equal(brokenHome.pass, false);
 assert.equal(brokenHome.exitCode, 1);
 
-const settings = resultFor("settings", ["appearance-radio"]);
+const settings = resultFor("settings", ["settings-panel"]);
 assert.equal(settings.pass, true);
 assert.equal(settings.tiers.L1.length, 0, "Settings must not inherit home/all L1 requirements");
-assert.deepEqual(settings.tiers.L2.map(({ key }) => key), ["appearance-radio"]);
+assert.deepEqual(settings.tiers.L2.map(({ key }) => key), ["settings-panel", "appearance-radio"]);
+assert.equal(settings.tiers.L2.find(({ key }) => key === "settings-panel").status, "ok");
+assert.equal(settings.tiers.L2.find(({ key }) => key === "appearance-radio").status, "miss");
 
 assert.equal(selectorMatchesScope("home+thread", { baseState: "thread", overlay: false }), true);
 assert.equal(selectorMatchesScope("home config", { baseState: "home", overlay: false }), true);