fix(windows): simplify Inno error messages

Author: Fei-Away

windows/installer/codex-dream-skin.iss

@@ -110,11 +110,8 @@ end;
 
 function InstallInitializationFailureMessage(const ExitCode: Integer): String;
 begin
-  Result := Format(
-    'Codex Dream Skin could not be initialized (exit code %d). ' +
-    'No installed application files were changed.',
-    [ExitCode]
-  );
+  Result := 'Codex Dream Skin could not be initialized (exit code ' +
+    IntToStr(ExitCode) + '). No installed application files were changed.';
 end;
 
 procedure CurStepChanged(CurStep: TSetupStep);
@@ -145,8 +142,8 @@ begin
   if not RunBootstrap(ExpandConstant('{app}\setup-bootstrap.ps1'), '-Uninstall', True, ExitCode) then
     RaiseException('Codex Dream Skin restoration could not be started. No installed files were removed.');
   if ExitCode <> 0 then
-    RaiseException(Format(
-      'Codex Dream Skin could not restore Codex (exit code %d). No installed files were removed.',
-      [ExitCode]
-    ));
+    RaiseException(
+      'Codex Dream Skin could not restore Codex (exit code ' +
+      IntToStr(ExitCode) + '). No installed files were removed.'
+    );
 end;

windows/tests/installer-static.tests.ps1

@@ -70,7 +70,8 @@ foreach ($requiredDefinition in @(
   'procedure CurUninstallStepChanged(CurUninstallStep: TUninstallStep);',
   'if CurUninstallStep <> usUninstall then',
   "RunBootstrap(ExpandConstant('{app}\setup-bootstrap.ps1'), '-Uninstall', True, ExitCode)",
-  'RaiseException(Format('
+  "'Codex Dream Skin could not restore Codex (exit code ' +",
+  "IntToStr(ExitCode) + '). No installed files were removed.'"
 )) {
   if (-not $definition.Contains($requiredDefinition)) {
     throw "Inno Setup definition is missing a release safety contract: $requiredDefinition"
@@ -85,7 +86,10 @@ $runBootstrapIndex = $definition.IndexOf(
   "RunBootstrap(ExpandConstant('{app}\setup-bootstrap.ps1'), '-Uninstall', True, ExitCode)",
   [System.StringComparison]::Ordinal
 )
-$uninstallFailureIndex = $definition.LastIndexOf('RaiseException(Format(', [System.StringComparison]::Ordinal)
+$uninstallFailureIndex = $definition.LastIndexOf(
+  "'Codex Dream Skin could not restore Codex (exit code ' +",
+  [System.StringComparison]::Ordinal
+)
 if ($uninstallStepIndex -lt 0 -or $runBootstrapIndex -le $uninstallStepIndex -or
   $uninstallFailureIndex -le $runBootstrapIndex -or
   $definition.Contains('function InitializeUninstall(): Boolean;')) {