fix(windows): enforce theme schemaVersion at runtime (#288)

* fix(windows): enforce theme schemaVersion at runtime

* fix(windows): write schema version for generated themes

Author: rwang23

windows/scripts/injector.mjs

@@ -525,6 +525,9 @@ export async function loadTheme(themeDir) {
   if (!raw || typeof raw !== "object" || Array.isArray(raw)) {
     throw new Error("Theme root must be an object");
   }
+  if (raw.schemaVersion !== 1) {
+    throw new Error("Theme must use schemaVersion 1");
+  }
   const image = normalizedText(raw.image, "image", null, 240);
   if (!image || path.isAbsolute(image)) throw new Error("Theme image must be a relative path");
   const imagePath = path.resolve(realThemeDir, image);
@@ -561,6 +564,7 @@ export async function loadTheme(themeDir) {
     line: normalizeThemeColor(rawColors?.line, "rgba(124, 255, 70, .28)"),
   };
   const theme = {
+    schemaVersion: 1,
     id: normalizeThemeText(raw.id, "custom", 80, "id", themePath),
     name: normalizeThemeText(raw.name, "Codex Dream Skin", 80, "name", themePath),
     brandSubtitle: normalizeThemeText(raw.brandSubtitle, "CODEX DREAM SKIN", 120, "brandSubtitle", themePath),

windows/scripts/theme-windows.ps1

@@ -594,6 +594,7 @@ function Set-DreamSkinActiveTheme {
   try { $oldImage = (Read-DreamSkinTheme -ThemeDirectory $paths.Active).ImagePath } catch {}
   if ($null -eq $Theme) {
     $Theme = [pscustomobject]@{
+      schemaVersion = 1
       id = 'custom'
       name = '自定义主题'
       appearance = 'auto'

windows/tests/theme-schema-contract.test.mjs

@@ -0,0 +1,51 @@
+import assert from "node:assert/strict";
+import fs from "node:fs/promises";
+import os from "node:os";
+import path from "node:path";
+import test from "node:test";
+import { fileURLToPath } from "node:url";
+import { loadTheme } from "../scripts/injector.mjs";
+
+const here = path.dirname(fileURLToPath(import.meta.url));
+const windowsRoot = path.resolve(here, "..");
+const sourceImage = path.join(windowsRoot, "assets", "dream-reference.jpg");
+
+async function makeTheme(root, schemaVersion, includeSchema = true) {
+  await fs.copyFile(sourceImage, path.join(root, "background.jpg"));
+  const theme = {
+    id: "schema-contract-fixture",
+    name: "Schema contract fixture",
+    image: "background.jpg",
+  };
+  if (includeSchema) theme.schemaVersion = schemaVersion;
+  await fs.writeFile(path.join(root, "theme.json"), `${JSON.stringify(theme, null, 2)}\n`);
+}
+
+async function withTheme(schemaVersion, includeSchema, callback) {
+  const root = await fs.mkdtemp(path.join(os.tmpdir(), "dreamskin-schema-contract."));
+  try {
+    await makeTheme(root, schemaVersion, includeSchema);
+    await callback(root);
+  } finally {
+    await fs.rm(root, { recursive: true, force: true });
+  }
+}
+
+test("Windows runtime accepts and preserves theme schemaVersion 1", async () => {
+  await withTheme(1, true, async (root) => {
+    const loaded = await loadTheme(root);
+    assert.equal(loaded.theme.schemaVersion, 1);
+  });
+});
+
+test("Windows runtime rejects missing and future theme schema versions", async () => {
+  await withTheme(undefined, false, async (root) => {
+    await assert.rejects(loadTheme(root), /must use schemaVersion 1/);
+  });
+  await withTheme(2, true, async (root) => {
+    await assert.rejects(loadTheme(root), /must use schemaVersion 1/);
+  });
+  await withTheme("1", true, async (root) => {
+    await assert.rejects(loadTheme(root), /must use schemaVersion 1/);
+  });
+});