Skip to content

Commit ed500fe

Browse files
committed
chore: deprecate piece metadata getters
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
1 parent f41a476 commit ed500fe

8 files changed

Lines changed: 20 additions & 0 deletions

File tree

docs/src/content/docs/developer-guides/storage/storage-operations.mdx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,9 @@ console.log(`Found ${pieces.length} pieces`);
240240
### Getting Piece Metadata
241241

242242
Access custom metadata attached to individual pieces:
243+
:::caution[Deprecated]
244+
Piece metadata getters are deprecated and will be removed from Synapse SDK packages. Read metadata from `PieceAdded` events or an indexer instead. Passing piece metadata when uploading or committing remains supported so providers can include it in those events.
245+
:::
243246

244247
```ts twoslash
245248
// @lib: esnext,dom

docs/src/content/docs/developer-guides/synapse-react.mdx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,4 +186,8 @@ const StorageExample = () => {
186186
};
187187
```
188188

189+
:::caution[Deprecated]
190+
The `metadata` field returned for each piece by `useDataSets()` depends on deprecated FWSS piece metadata getters and will be removed. Read piece metadata from `PieceAdded` events or an indexer instead.
191+
:::
192+
189193
Check out the [Synapse React Reference](/reference/filoz/synapse-react/toc/) for all available query and mutation hooks.

packages/synapse-core/src/pdp-verifier/get-pieces.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ export namespace getPiecesWithMetadata {
155155
* fewer or no visible items. Treat `nextCursor` as opaque and use
156156
* {@link paginate} to traverse every page.
157157
*
158+
* @deprecated FWSS piece metadata getters are being removed. Use {@link getPieces} and read metadata from `PieceAdded` events or an indexer instead.
159+
*
158160
* @example Read the first page
159161
* ```ts
160162
* import { getPiecesWithMetadata } from '@filoz/synapse-core/pdp-verifier'

packages/synapse-core/src/warm-storage/get-all-piece-metadata.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export namespace getAllPieceMetadata {
3737
/**
3838
* Get all metadata for a piece formatted as a MetadataObject
3939
*
40+
* @deprecated FWSS piece metadata getters are being removed. Read metadata from `PieceAdded` events or an indexer instead.
4041
* @param client - The client to use to get the piece metadata.
4142
* @param options - {@link getAllPieceMetadata.OptionsType}
4243
* @returns The metadata formatted as a MetadataObject {@link getAllPieceMetadata.OutputType}
@@ -90,6 +91,7 @@ export namespace getAllPieceMetadataCall {
9091
*
9192
* Use {@link parseAllPieceMetadata} to parse the output into a MetadataObject.
9293
*
94+
* @deprecated FWSS piece metadata getters are being removed. Read metadata from `PieceAdded` events or an indexer instead.
9395
* @param options - {@link getAllPieceMetadataCall.OptionsType}
9496
* @returns The call to the getAllPieceMetadata function {@link getAllPieceMetadataCall.OutputType}
9597
* @throws Errors {@link getAllPieceMetadataCall.ErrorType}
@@ -132,6 +134,7 @@ export function getAllPieceMetadataCall(options: getAllPieceMetadataCall.Options
132134
/**
133135
* Parse the contract output into a MetadataObject
134136
*
137+
* @deprecated The FWSS piece metadata getter is being removed. Read metadata from `PieceAdded` events or an indexer instead.
135138
* @param data - The contract output from the getAllPieceMetadata function {@link getAllPieceMetadata.ContractOutputType}
136139
* @returns The metadata formatted as a MetadataObject {@link getAllPieceMetadata.OutputType}
137140
*/

packages/synapse-core/src/warm-storage/types.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ export interface Piece {
5656
url: string
5757
}
5858

59+
/**
60+
* @deprecated FWSS piece metadata getters are being removed. Use {@link Piece} and read metadata from `PieceAdded` events or an indexer instead.
61+
*/
5962
export interface PieceWithMetadata extends Piece {
63+
/** @deprecated Read metadata from `PieceAdded` events or an indexer instead. */
6064
metadata: MetadataObject
6165
}

packages/synapse-core/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"extends": "../../tsconfig.json",
33
"compilerOptions": {
44
"outDir": "./dist",
5+
"removeComments": false,
56
"types": ["mocha", "node"]
67
},
78
"include": ["src", "test"],

packages/synapse-sdk/src/warm-storage/service.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,7 @@ export class WarmStorageService {
342342
/**
343343
* Get all metadata for a piece in a data set
344344
*
345+
* @deprecated FWSS piece metadata getters are being removed. Read metadata from `PieceAdded` events or an indexer instead.
345346
* @param options - Options for the piece
346347
* @param options.dataSetId - The data set ID
347348
* @param options.pieceId - The piece ID
@@ -354,6 +355,7 @@ export class WarmStorageService {
354355
/**
355356
* Get specific metadata key for a piece in a data set
356357
*
358+
* @deprecated FWSS piece metadata getters are being removed. Read metadata from `PieceAdded` events or an indexer instead.
357359
* @param options - Options for the piece
358360
* @param options.dataSetId - The data set ID
359361
* @param options.pieceId - The piece ID

packages/synapse-sdk/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"extends": "../../tsconfig.json",
33
"compilerOptions": {
44
"outDir": "./dist",
5+
"removeComments": false,
56
"types": ["mocha", "node"]
67
},
78
"include": ["src/**/*", "package.json", "../synapse-core/src/utils/epoch.ts", "../synapse-core/test/epoch.test.ts"],

0 commit comments

Comments
 (0)