IMultiTenantContextAccessor returns null when not using UseMiddleware

[andrijanabe]

We have an issue when trying to use the Finbuckle.Multitenant library when using it in cases when we use Messaging (and no HttpRequests), meaning that we are not utilising the UseMiddleware, therefore the IMultiTenantContextAccessor is not populated.

Can you please suggest a way how we can use this library in such scenarios?

[AndrewTriesToCode]

Hi, my apologies for the slow reply. In this I recommend that you essentially mimic what the middleware is doing:

var accessor = context.RequestServices.GetRequiredService<IMultiTenantContextAccessor>();

if (accessor.MultiTenantContext == null)
{
    var resolver = context.RequestServices.GetRequiredService<ITenantResolver>();
    var multiTenantContext = await resolver.ResolveAsync(context);
    accessor.MultiTenantContext = multiTenantContext;
}

if (next != null)
{
    await next(context);
}

The key here is that it is getting an instance of ITenantResolver and simply calling ResolveAsync on it.

You can new up a TenantResolver yourself without DI but it's a little more trouble to plug in the needed ctor parameters:

public TenantResolver(IEnumerable<IMultiTenantStrategy> strategies, IEnumerable<IMultiTenantStore<T>> stores, IOptionsMonitor<MultiTenantOptions> options, ILoggerFactory loggerFactory)

If you have only a single strategy and store you can simplify things significantly:

// assumes you have a strategy and store instance
var identifier = await strategy.GetIdentifierAsync(context);
var tenantInfo = await store.TryGetByIdentifierAsync(identifier);
``

[ievgenii-shepeliuk]

Hello @AndrewTriesToCode

As a continuation for this post, is it possible to just make _asyncLocalContext property of MultiTenantContextAccessor not internal ?

Because in cases, when used outside Asp.Net, it's impossible to populate this context from some custom code.
One always needs to create and register in DI own implementation of IMultiTenantContextAccessor.

If this proposal is considered contradicting to the library design, it would be great to extend the library somehow in other way to make usage outside of Asp.Net easier.

[VictorioBerra]

@ievgenii-shepeliuk I am going to leave that one forAndrew to answer, but I wanted to ask what way are you leveraging this outside of ASPNET? Isn't the whole point of this library to allow someone to rapidly add multi-tenancy to an ASPNET Web application?

[ievgenii-shepeliuk]

@ievgenii-shepeliuk I am going to leave that one forAndrew to answer, but I wanted to ask what way are you leveraging this outside of ASPNET? Isn't the whole point of this library to allow someone to rapidly add multi-tenancy to an ASPNET Web application?

Hello @VictorioBerra, answering

1. This project's README says following, there's no restrictions to use within ASP.NET

   Finbuckle.MultiTenant is an open-source multitenancy middleware library for .NET. It enables tenant resolution, per-tenant app behavior, and per-tenant data isolation.

   Although middleware may be treated as ASP.NET middleware - there's no direct restriction to ASP.NET web apps :))

2. We create multi-tenant applications that don't expose REST / gRPC, but consume / produce messages from/to Kafka, although they still need to be tenant aware, so this library is a great fit, except that small context population issue.

[AndrewTriesToCode]

Hi I can give a more detailed answer later today but I'm assuming you are using the .Net Generic Host to handle DI and app lifetime. Is that correct?

[ievgenii-shepeliuk]

Hi I can give a more detailed answer later today but I'm assuming you are using the .Net Generic Host to handle DI and app lifetime. Is that correct?

Hello @AndrewTriesToCode

Yes it is correct.
I've implemented own IMultiTenantContextAccessor to be able to populate multitenant context outside of HTTP flow and library works fine.
My request is just for simplifying the library experience for use cases like mine, non related to web apps.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ievgenii-shepeliuk]

Hello @AndrewTriesToCode
Can you please reopen this issue since it is still relevant and not addressed.

[ievgenii-shepeliuk]

@AndrewTriesToCode This issue is not solved.

[AndrewTriesToCode]

Yeah and I'll pin it to prevent closure. Sorry!